Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghost replay selection fix #3081

Merged
merged 4 commits into from
Dec 28, 2017
Merged

Ghost replay selection fix #3081

merged 4 commits into from
Dec 28, 2017

Conversation

Supernova4422
Copy link
Contributor

To fix: #3034

Example: https://i.imgur.com/WRniypS.png

A simple solution to this issue, alternative solutions are to make it " " instead of "Unknown."

@Supernova4422
Copy link
Contributor Author

Supernova4422 commented Dec 23, 2017

Changed it to be language neutral and instead have no text: https://i.imgur.com/WEwZD4m.png

@auriamg
Copy link
Member

auriamg commented Dec 27, 2017

Okay, but why must it be a whitespace character? Couldn't it just be an empty string "" ?

@auriamg
Copy link
Member

auriamg commented Dec 27, 2017

What I was trying to say in my previous comment is : I guess I'd prefer to understand the root of the problem, rather than patching it locally by adding spaces. If you can't find the root of the issue I guess that's still better than nothing though

@Supernova4422
Copy link
Contributor Author

@auriamg The issue is that there are three vectors that are inserted values for each replay, however when a username doesn't exist it doesn't insert a value into the column. Therefore when it comes to display it, since there are less values than other columns fucky stuff happens.

Therefore having strings be inserted in place of actual values is a solution, and it doesn't disrupt existing setups or add more unecessary load. The only other fix I can think of is the parameter that's "false" may have other inputs or settings for this scenario.

@auriamg auriamg merged commit 7c10a55 into supertuxkart:master Dec 28, 2017
@auriamg
Copy link
Member

auriamg commented Dec 28, 2017

Merged, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Badly adjusted playername for replays
2 participants