bindings/go/blst.go: fix logical error in SigValidate.

Thanks to Yunjong Jeong (@blukat29) for report.
supranational · Aug 9, 2023 · fb91221 · fb91221
1 parent c6a3cc0
commit fb91221
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/bindings/go/blst.go b/bindings/go/blst.go
@@ -472,8 +472,10 @@ func (pk *P1Affine) KeyValidate() bool {
 // always cryptographically safe, but application might want
 // to guard against obviously bogus individual[!] signatures.
 func (sig *P2Affine) SigValidate(sigInfcheck bool) bool {
-	return (sigInfcheck && !bool(C.blst_p2_affine_is_inf(sig))) ||
-		bool(C.blst_p2_affine_in_g2(sig))
+	if sigInfcheck && bool(C.blst_p2_affine_is_inf(sig)) {
+		return false
+	}
+	return bool(C.blst_p2_affine_in_g2(sig))
 }
 
 //
@@ -1090,8 +1092,10 @@ func (pk *P2Affine) KeyValidate() bool {
 // always cryptographically safe, but application might want
 // to guard against obviously bogus individual[!] signatures.
 func (sig *P1Affine) SigValidate(sigInfcheck bool) bool {
-	return (sigInfcheck && !bool(C.blst_p1_affine_is_inf(sig))) ||
-		bool(C.blst_p1_affine_in_g1(sig))
+	if sigInfcheck && bool(C.blst_p1_affine_is_inf(sig)) {
+		return false
+	}
+	return bool(C.blst_p1_affine_in_g1(sig))
 }
 
 //

diff --git a/bindings/go/blst_minpk.tgo b/bindings/go/blst_minpk.tgo
@@ -24,8 +24,10 @@ func (pk *P1Affine) KeyValidate() bool {
 // always cryptographically safe, but application might want
 // to guard against obviously bogus individual[!] signatures.
 func (sig *P2Affine) SigValidate(sigInfcheck bool) bool {
-    return (sigInfcheck && !bool(C.blst_p2_affine_is_inf(sig))) ||
-           bool(C.blst_p2_affine_in_g2(sig))
+    if sigInfcheck && bool(C.blst_p2_affine_is_inf(sig)) {
+        return false
+    }
+    return bool(C.blst_p2_affine_in_g2(sig))
 }
 
 //