Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tqdm() library and remove pytorch_classification Bar #183

Merged
merged 1 commit into from
May 6, 2020

Conversation

mikhail
Copy link
Contributor

@mikhail mikhail commented May 1, 2020

I removed individual game-specific dependencies as well, though I'd really love to see all these copy-paste files go away and have one top-level file that is configurable (either via main.py file or better yet - some config file inside of game directories!)

This addresses the tqdm bit of #180

@suragnair
Copy link
Owner

There seem to be some conflicts after merging the logging PR. Also, previously the training steps would print the running loss_pi and loss_v. Would it be possible to incorporate those in the tqdm bars?

@mikhail
Copy link
Contributor Author

mikhail commented May 5, 2020

Yep! I'll resolve the conflicts and add those values back as a suffix to tqdm

@mikhail
Copy link
Contributor Author

mikhail commented May 6, 2020

Updated! Looks like this now:
image

@suragnair
Copy link
Owner

This is awesome! It cleans up a lot of bookkeeping code and hopefully makes the code easier to use. Thanks very much. Would be open to other suggestions for overall repo hygiene.

@suragnair suragnair merged commit 4a89361 into suragnair:master May 6, 2020
@mikhail mikhail deleted the rm_ptc branch May 6, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants