Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading an SC2P file doesn't reset the synth #155

Closed
baconpaul opened this issue Jan 20, 2022 · 2 comments
Closed

Loading an SC2P file doesn't reset the synth #155

baconpaul opened this issue Jan 20, 2022 · 2 comments

Comments

@baconpaul
Copy link
Contributor

Right now when you load a patch the synth doesn't reset to empty first. This is confusing and error prone. And just weird.

@djtuBIG-MaliceX
Copy link
Contributor

djtuBIG-MaliceX commented Jan 21, 2022

This one not so sure if it should be a 'global' reset. Certainly a channel-based reset, if the understanding is that SC2P patches are channel-independent. It would make sense for SC1-style multi (*.scm) patches however, which currently do not exist in SC2.

@baconpaul
Copy link
Contributor Author

The answer was to set replace to true in the drag and drop action. We can also add a load action for SC2P properly so I'll leave this open but will improve it in a quick merge tonight.

baconpaul added a commit to baconpaul/shortcircuit-xt that referenced this issue Feb 8, 2022
When we do a drop of a multifile, set the zone drop in
replace mode not add zone mode. Addresses surge-synthesizer#155

Save SC2 multifiles as .sc2m extension not .sc2p
baconpaul added a commit that referenced this issue Feb 8, 2022
When we do a drop of a multifile, set the zone drop in
replace mode not add zone mode. Addresses #155

Save SC2 multifiles as .sc2m extension not .sc2p
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants