-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VST3-Win: MIDI control issues #26
Comments
What OS do you use, what daw do you use, do you use the VST2 or VST3 version, which version of surge is used? |
Windows 10
Reaper 5.95
VST3
Surge 1.6.0b3
Den fre 5 okt. 2018 09:22Leo <notifications@github.com> skrev:
… What OS do you use, what daw do you use, do you use the VST2 or VST3
version, which version of surge is used?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/kurasu/surge/issues/26#issuecomment-427270434>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/APAZwMGOgWsuiN7owiVCbaG1-uK_LiZkks5uhwiwgaJpZM4XGr0C>
.
|
Nice form. I'll try to bug report/troubleshoot that organized next time.
Den fre 5 okt. 2018 15:43Leo <notifications@github.com> skrev:
… *Disclaimer: I'm not a surge/audio plugin developer, just suggesting
common troubleshooting steps, which is usually to test what works and what
doesn't to narrow down the source of the issue.*
Okay, I just tested it and can confirm that this issue is present on my
setup when Surge v1.6.0b3 is loaded as VST3. However, the VST2 version
works fine.
*- Test 1.1 - (Issue occuring)*
Windows 10
Bitwig Studio v2.4
Surge v1.6.0b3, VST3
(Alesis Hardware Controller sending CC)
*- Test 2 - (Issue occuring)*
Windows 10
Bitwig Studio v2.4
Surge v1.6.0b3, VST3
(Bitwig Studio generating and sending CC)
*- Test 3 - (Issue NOT occuring)*
Windows 10
Bitwig Studio v2.4
Surge v1.6.0b3, VST2
(Alesis Hardware Controller sending CC)
*Workaround*
If you still want to use the VST3 version with the expressions / mod- &
pitchbendwheel, modulate the parameters via your daws VST-Parameter control
page.
[image: surgeworkaround]
<https://user-images.githubusercontent.com/26248671/46538649-d0599380-c8b4-11e8-98c0-644c1de36da5.PNG>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/kurasu/surge/issues/26#issuecomment-427370390>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/APAZwBQ_bsfw04RjJw86Nh31J72BPCsQks5uh2HkgaJpZM4XGr0C>
.
|
thank god, i went all over the place looking for drivers and that. being this is the only VST i had installed on a new machine... so can also confirm the whole pitch bend / mod wheel data isn't getting to this. i finally installed another free one and it pitchbent just fine... that being said, this is basically my favorite synth plugin, and i was well excited to see it come back for x64 finally! i can't use it in osx/logic anymore as it refuses 32bit plugs =( win 10 |
As stated in my post above, the VST 2 version works fine! Its just the VST3 version that has these hickups. |
please, could you change the title of this from |
Done! |
btw, is this issue still happening for you guys? @funkaloss @cyanit -- talking about 8th January 2019 build.. |
I'm experiencing it on the Feb. 28th nightly build. VST2 works as expected, VST3 doesn't recieve pitch (and I'm assuming other MIDI data as well. |
Thanks @bit-101010 And: Makes sense - we haven’t fixed it yet! But we plan on doing so. Don’t suppose you have some asset like a bitwig file which shows the difference do you? That would help |
I don't have Bitwig, the best I could do is REAPER. I'll conjure up something if that works for you. If not, I can ask some friendly local bitwig users. |
Sure I can try in reaper. Or just a bit more clarity on "how you show it broken" would be helpful! Thank you for anything you can share. |
I will get on it! |
This is the Reaper File as well as the rendered audio. The first measure uses the modwheel to change the wave shape (of the sawtooth), the next measure uses a +/- 24 semitone pitchbend. These are both audible on the VST2 plugin. Afterwards, the same modulations are applied to the VST3 plugin, and no noticeable changes arise. |
Thank you very much! |
Also - just so you aren't disappointed - our list is a bit long. We will get to this before 1.6.0 but it may not be a few weeks. The zip file will stay here though ready for us to debug and is super useful! |
In VST3 NoteOnEvent::velocity is a float between 0 and 1. Why? Who knows. But in every other midi thing it is a char between 0 and 127. So when passed to surge directly in VST3 it doesn't work. This change simply multiplies the velocity and casts it to a char. addresses parts of issues surge-synthesizer#389 and surge-synthesizer#26 but not all of them
In VST3 NoteOnEvent::velocity is a float between 0 and 1. Why? Who knows. But in every other midi thing it is a char between 0 and 127. So when passed to surge directly in VST3 it doesn't work. This change simply multiplies the velocity and casts it to a char. addresses parts of issues surge-synthesizer#389 and surge-synthesizer#26 but not all of them
Yeah OK so I see why this is happening. none of the code exists! Like other than note on, note off, and poly pressure, the whole shebang is ignored in the vst3. I just fixed up velocity but the 'tuning' in the same spot is a float-vs-char, the mod wheel and all controls are ignored, etc... basically it looks like the vst3 host is half written in this regard. So it's a good clean thing to fix one day. |
In VST3 NoteOnEvent::velocity is a float between 0 and 1. Why? Who knows. But in every other midi thing it is a char between 0 and 127. So when passed to surge directly in VST3 it doesn't work. This change simply multiplies the velocity and casts it to a char. addresses parts of issues #389 and #26 but not all of them
This commit implements the core non-MPE VST3 features which were missing on mac and windows. * Parameter names are long names in VST3 and were swprintfed as such even though they are non-wchar in surge internals * Parameter changes in VST3 flow to the UI and adjust widgets * Bound parameters in the DAW are named correctly * Midi controllers and pitch bend are captured and sent to surge * Unicode support is corrected for systems where wchar_t != char16 (like mac) Closes surge-synthesizer#766 VST3 names not correct when learning Closes surge-synthesizer#752 VST3 Automation in Bitwig Closes surge-synthesizer#26 VST3-Win MIDI Control Issues
This commit implements the core non-MPE VST3 features which were missing on mac and windows. * Parameter names are long names in VST3 and were swprintfed as such even though they are non-wchar in surge internals * Parameter changes in VST3 flow to the UI and adjust widgets * Bound parameters in the DAW are named correctly * Midi controllers and pitch bend are captured and sent to surge * Unicode support is corrected for systems where wchar_t != char16 (like mac) while still working on Windows, albeit in a somewhat clumsy fashion * Handle oddities around call type allow the plugin to also work 32 and 64 bit windows (Although demand for 32 bit VST3 seems more a formality than practicality, it does work) Closes surge-synthesizer#766 VST3 names not correct when learning Closes surge-synthesizer#752 VST3 Automation in Bitwig Closes surge-synthesizer#26 VST3-Win MIDI Control Issues
This commit implements the core non-MPE VST3 features which were missing on mac and windows. * Parameter names are long names in VST3 and were swprintfed as such even though they are non-wchar in surge internals * Parameter changes in VST3 flow to the UI and adjust widgets * Bound parameters in the DAW are named correctly * Midi controllers and pitch bend are captured and sent to surge * Unicode support is corrected for systems where wchar_t != char16 (like mac) while still working on Windows, albeit in a somewhat clumsy fashion * Handle oddities around call type allow the plugin to also work 32 and 64 bit windows (Although demand for 32 bit VST3 seems more a formality than practicality, it does work) Closes #766 VST3 names not correct when learning Closes #752 VST3 Automation in Bitwig Closes #26 VST3-Win MIDI Control Issues
Hi everyone I just pushed a change to the VST3 host which supports controllers, pitch bend, modulation, and also allows DAW automation to have the correct labels and behavior and interact cleanly with the GUI. The nightly should be rebuilt within an hour. If you want to try the nightly anytime after about 9:30am NYC time today and provide feedback if there are other VST3 bugs that would be great. I tested extensively in bitwig and didn’t find a differences between the VST3 and VST2; I don’t have other hosts as readily available for VST3 though so testing welcome. Either feel free to reopen this ticket if you find a bug or open a new one or let us know on slack. Thanks! |
In VST3 NoteOnEvent::velocity is a float between 0 and 1. Why? Who knows. But in every other midi thing it is a char between 0 and 127. So when passed to surge directly in VST3 it doesn't work. This change simply multiplies the velocity and casts it to a char. addresses parts of issues surge-synthesizer#389 and surge-synthesizer#26 but not all of them Former-commit-id: 94cc9ba43b99a81e231e45611210f9deca59a1db [formerly 38145e5] Former-commit-id: 5cc46364801412b4164f0a0e93ae8002e3d47715 Former-commit-id: d0cd176b508398c7a21cb0607c83768606364f05
This commit implements the core non-MPE VST3 features which were missing on mac and windows. * Parameter names are long names in VST3 and were swprintfed as such even though they are non-wchar in surge internals * Parameter changes in VST3 flow to the UI and adjust widgets * Bound parameters in the DAW are named correctly * Midi controllers and pitch bend are captured and sent to surge * Unicode support is corrected for systems where wchar_t != char16 (like mac) while still working on Windows, albeit in a somewhat clumsy fashion * Handle oddities around call type allow the plugin to also work 32 and 64 bit windows (Although demand for 32 bit VST3 seems more a formality than practicality, it does work) Closes surge-synthesizer#766 VST3 names not correct when learning Closes surge-synthesizer#752 VST3 Automation in Bitwig Closes surge-synthesizer#26 VST3-Win MIDI Control Issues Former-commit-id: b3221642eea1a25e891b1ca35963ad88dad02f00 [formerly 97d1366] Former-commit-id: 800f3f331fd31395ec96148e296f9154ee835761 Former-commit-id: b5c26e2c53dacfc4bf4489f77090ab4476b761c7
I discovered this gem when it became open source, and now I'm exploring it.
I can't seem to control Surge with my Nektar controller. The pitch of the keyboard works fine but nothing else: not velocity, pitch bend, mod wheel or any other fader or knob.
The text was updated successfully, but these errors were encountered: