VST3 Fixes for automation and midi #767
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements the core non-MPE VST3 features which were missing on mac and windows. * Parameter names are long names in VST3 and were swprintfed as such even though they are non-wchar in surge internals * Parameter changes in VST3 flow to the UI and adjust widgets * Bound parameters in the DAW are named correctly * Midi controllers and pitch bend are captured and sent to surge * Unicode support is corrected for systems where wchar_t != char16 (like mac) Closes surge-synthesizer#766 VST3 names not correct when learning Closes surge-synthesizer#752 VST3 Automation in Bitwig Closes surge-synthesizer#26 VST3-Win MIDI Control Issues
|
Sigh. Well back to the drawing board to fix that windows build error. Sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the core non-MPE VST3 features which were missing
on mac and windows.
even though they are non-wchar in surge internals
(like mac)
Closes #766 VST3 names not correct when learning
Closes #752 VST3 Automation in Bitwig
Closes #26 VST3-Win MIDI Control Issues