Use Python3 piggy packing the Linux binary #3655
Conversation
|
I've converted from Ableton Live user into Reaper user over last year, moved most of my music production to Linux, a lot thanks to recent developments (mainly PipeWire), and prefer keeping my VST's at my home directory, so using self-compiled Surge is the best bet for my needs :-) |
|
Thanks halpy to merge this but we are pausing merges for this week while we stabilize 18. Will merge it as soon as we know our merge strategy for either 181 or 19 |
|
NP. Merge when you see appropriate. I'm running now self-compiled main branch and obviously have this patch in my fork. |
|
I'll probably rebase this weekly basis up until it is merged as I want to run the latest and greatest... |
|
Yeah depending on our path the latest greatest might get a little rocky but I will merge this early in cycle so you can build close to 18 enjoy! |
|
If I find any other issues the fixes will be visible in this PR (assuming that I'm capable fixing them, otherwise I'll just report an issue). If you don't want to take all at once, |
|
Making the python-ness transparent by adding a shebang, removing the |
|
@mvf, NP I can refine this. Thanks for the feedback. Off-topic: how can I test run the new flashier skin seen in videos and screenshots? |
|
BTW, In my Debian system python does not point to python3, so should I consider Debian default install is improperly configured? :-) I guess I need to install |
|
@jarkk0sakkinen The new skin is in the latest release. Just right click anywhere on the interface and go to Skins -> Royal Surge. |
|
I use self-compiled master mostly because I prefer a local install over deb and also to keep in phase where things are going. I did a compile of the master when I submitted this patch. Was it added after that, or do I do some tricks to get it working? Does it get piggy packed to the binary? |
1. Rename emit-vector-piggy.py as emit-vector-piggy. 2. Rename generate-lv2-ttl.py as generate-lv2-ttl. 3. Give +x for both. 4. Use /usr/bin/env to find the location of the interpreter in the POSIX standard manner, thus making the whole compilation process more distro agnostic. See: https://pubs.opengroup.org/onlinepubs/9699919799/utilities/env.html Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@iki.fi>
|
OK, now the commit has been updated (and the commit message has been changed accordingly). |
|
Sorry about the "properly configured" it's a bit snarky and not very accurate. For the Debian GNOME install I reckon Python was only installed as a dependency and there was no need to install a Anyhow, looks good now, merging! |
|
Uhhh.... you merged this @mvf? I was hoping to wait until after 181. Are we sure it works on all our distros including Rpi |
|
@jarkk0sakkinen if you self build you will need to stage the extra content repo. The new skin is in a separate repo which isn’t a submodule. There’s a cmake rule to do it |
|
Oh I see merged with oyhton3 renamed to python. All good |
|
@baconpaul, Thanks, I'll look into it. |
|
Or just clone surge-extra-content into your documents surge folder more easily |
|
Sounds like better plan thank you :-) |
As Python2 has been EOL for over a year already, move on using Python3. The
use of Python2 is likely cause the following buid error in recent versions
of various popular Linux distributions:
Do the migration by
emit-vector-piggy.pyasemit-vector-piggy.generate-lv2-ttl.pyasgenerate-lv2-ttl./usr/bin/envto find the location of the interpreter in thePOSIX standard manner, thus making the whole compilation process more
distro agnostic.
[*] https://pubs.opengroup.org/onlinepubs/9699919799/utilities/env.html
Signed-off-by: Jarkko Sakkinen jarkko.sakkinen@iki.fi