Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc on select example #2064

Merged
merged 1 commit into from
May 28, 2023
Merged

Fix doc on select example #2064

merged 1 commit into from
May 28, 2023

Conversation

Odonno
Copy link
Contributor

@Odonno Odonno commented May 28, 2023

Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.

What is the motivation?

I noticed something wrong on the example doc of the select function:

// You can skip an unnecessary option if you know the record already exists
let person: Option<Person> = db.select(("person", "h5wxrf2ewk8xjxosxtyc")).await?;

It says we can skip the Option<T> to use just T but the code below the comment does not reflect it.

What does this change do?

Fix the example documentation

What is your testing strategy?

N/A

Is this related to any issues?

If this pull request is related to any other pull request or issue, or resolves any issues - then link all related pull requests and issues here.

Have you read the Contributing Guidelines?

@Odonno Odonno changed the title Fix example on select example Fix doc on select example May 28, 2023
@tobiemh tobiemh merged commit f6c909e into surrealdb:main May 28, 2023
@Odonno Odonno deleted the patch-1 branch May 28, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants