Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add sdk build test #4092

Merged
merged 4 commits into from
May 24, 2024
Merged

[CI] Add sdk build test #4092

merged 4 commits into from
May 24, 2024

Conversation

emmanuel-keller
Copy link
Contributor

@emmanuel-keller emmanuel-keller commented May 24, 2024

What is the motivation?

Following #4041, we want to be sure the SDK builds seamlessly.

It is a forward port of #4050.

What does this change do?

Introduces two mini cargo projects that include the library (SDK):

  1. for local server (kv-mem)
  2. With a remote client (ws).

What is your testing strategy?

Two test have been written and added to the CI.

Is this related to any issues?

Closes #4041

Does this change need documentation?

  • No documentation needed

Have you read the Contributing Guidelines?

@emmanuel-keller emmanuel-keller marked this pull request as ready for review May 24, 2024 11:25
@emmanuel-keller emmanuel-keller requested review from a team and tobiemh as code owners May 24, 2024 11:25
@emmanuel-keller emmanuel-keller added the topic:sdks This is related to one or more SDKs label May 24, 2024
@tobiemh tobiemh added this pull request to the merge queue May 24, 2024
Merged via the queue into main with commit bbab9fb May 24, 2024
23 checks passed
@tobiemh tobiemh deleted the emmanuel/rust-sdk-check branch May 24, 2024 18:34
@rushmorem rushmorem added this to the v2.0.0-alpha.1 milestone Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:sdks This is related to one or more SDKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Rust fails to build surrealdb
4 participants