Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sortable list text changing not working on typing or on blur #204

Closed
WoodenPC opened this issue Jul 16, 2020 · 6 comments
Closed

sortable list text changing not working on typing or on blur #204

WoodenPC opened this issue Jul 16, 2020 · 6 comments
Assignees
Milestone

Comments

@WoodenPC
Copy link

Are you requesting a feature, reporting a bug or ask a question?

bug

What is the current behavior?

text changing after adding or removing item in sortable list

What is the expected behavior?

text changing on typing or on blur

How would you reproduce the current behavior (if this is a bug)?

https://surveyjs.io/Examples/Builder/?id=customwidgets
select sortable list widget, open choices property, change text in any item -> text is not updating on view

Provide the test code and the tested page URL (if applicable)

Tested page URL:
https://surveyjs.io/Examples/Builder/?id=customwidgets

Specify your

  • browser: google chrome/ firefox
  • editor version: last version
@tsv2013
Copy link
Member

tsv2013 commented Jul 21, 2020

Thank you for the report. We'll take a look.

@andrewtelnov andrewtelnov transferred this issue from surveyjs/survey-creator Jul 21, 2020
@andrewtelnov andrewtelnov added this to the v1.7.21 milestone Jul 21, 2020
@andrewtelnov
Copy link
Member

andrewtelnov commented Jul 21, 2020

@WoodenPC I have fixed the issue. We will include the fix in v1.7.21 that we are going to release today/tomorrow.

Thank you,
Andrew

@WoodenPC
Copy link
Author

Thank you very much! @andrewtelnov please look at the other props too, it seems that update of "empty text" prop also not working. Idk, maybe this problem can be related to other props in sortablelist widget?
image

@andrewtelnov
Copy link
Member

@WoodenPC I have fixed it as well and move properties into "general" tab.

Thank you,
Andrew

@WoodenPC
Copy link
Author

@andrewtelnov Are u sure "empty text" is fixed ? I checked it again and seems it still broken

@andrewtelnov
Copy link
Member

@WoodenPC It is fixed in v1.7.24 that we are not released yet. You did not create a new issue, that is why there is a misunderstanding. Here is the commit.

Thank you,
Andrew

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants