Skip to content

Commit

Permalink
Fix paneldynamic getQuestions() method when panels count is 0.
Browse files Browse the repository at this point in the history
  • Loading branch information
Dmitry Kuzin (DevExpress) committed Feb 18, 2020
1 parent cf53a47 commit 3d5ddb7
Show file tree
Hide file tree
Showing 2 changed files with 37 additions and 4 deletions.
7 changes: 3 additions & 4 deletions src/visualizationPanelDynamic.ts
@@ -1,7 +1,7 @@
import { VisualizerBase } from "./visualizerBase";
import { VisualizationManager } from "./visualizationManager";
import { VisualizationPanel } from "./visualizationPanel";
import { Question, QuestionPanelDynamicModel } from "survey-core";
import { Question, QuestionPanelDynamicModel, IQuestion } from "survey-core";

export class VisualizationPanelDynamic extends VisualizerBase {
constructor(
Expand All @@ -19,9 +19,9 @@ export class VisualizationPanelDynamic extends VisualizerBase {
);
}

getQuestions() {
getQuestions(): IQuestion[] {
const paneldynamic: QuestionPanelDynamicModel = <any>this.question;
return paneldynamic.panels[0].questions;
return paneldynamic.template.questions;
}

render() {
Expand All @@ -32,7 +32,6 @@ export class VisualizationPanelDynamic extends VisualizerBase {
);
visPanel.render();
}

}

VisualizationManager.registerVisualizer(
Expand Down
34 changes: 34 additions & 0 deletions tests/visualizationPanelDynamic.test.ts
@@ -0,0 +1,34 @@
import { SurveyModel, QuestionTextModel } from "survey-core";
import { VisualizationPanelDynamic } from "../src/visualizationPanelDynamic";

test("check paneldynamic visualization getQuestions() when panels count is 0", () => {
const json = {
elements: [
{
name: "question1",
type: "paneldynamic",
isRequired: true,
templateElements: [
{
type: "text",
name: "question2"
}
]
}
]
};
const data = [
{
question1: [{ question2: "testValue" }]
}
];
const survey = new SurveyModel(json);
const question = survey.getAllQuestions()[0];
const viz = new VisualizationPanelDynamic(
document.createElement("div"),
<any>question,
data,
{}
);
expect(viz.getQuestions()).toBeTruthy();
});

0 comments on commit 3d5ddb7

Please sign in to comment.