Resolved #5347 - The creator.onNotify event - Introduce an additional…

… parameter which would determine the type (info or error) of a notification message (#5354) Co-authored-by: tsv2013 <tsv2013@noreply.github.com>
surveyjs · Mar 28, 2024 · 41c85fa · 41c85fa
1 parent b0eea10
commit 41c85fa
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/packages/survey-creator-core/src/creator-base.ts b/packages/survey-creator-core/src/creator-base.ts
@@ -2133,7 +2133,7 @@ export class SurveyCreatorModel extends Base
       this.notifier.notify(message, type);
       // alert(message);
     } else {
-      this.onNotify.fire(this, { message: message });
+      this.onNotify.fire(this, { message, type });
     }
   }
 

diff --git a/packages/survey-creator-core/src/creator-events-api.ts b/packages/survey-creator-core/src/creator-events-api.ts
@@ -613,6 +613,10 @@ export interface NotifyEvent {
    * A message to display.
    */
   message: string;
+  /**
+   * Notification type: "info" or "error", "info" is the default value.
+   */
+  type: string;
 }
 
 export interface ElementFocusingEvent {

diff --git a/packages/survey-creator-core/tests/creator-base-v1.tests.ts b/packages/survey-creator-core/tests/creator-base-v1.tests.ts
@@ -228,11 +228,14 @@ test("Editor state property", () => {
   //Add a case for Bug #1447
   creator.showErrorOnFailedSave = true;
   let notifyMessage;
+  let notifyType;
   creator.onNotify.add((sender: any, options: any) => {
     notifyMessage = options.message;
+    notifyType = options.type;
   });
   creator.doSaveFunc();
   expect(notifyMessage).toBeTruthy();
+  expect(notifyType).toEqual("error");
   expect(creator.state).toEqual("modified");
 });