#5225 A SurveyJS Creator appears incorrectly when a parent container'…

…s height is unspecified Fixes #5225
surveyjs · Feb 27, 2024 · 5d856a7 · 5d856a7
1 parent fa64bc2
commit 5d856a7
Show file tree

Hide file tree

Showing 3 changed files with 46 additions and 2 deletions.
diff --git a/packages/survey-creator-core/src/components/question.scss b/packages/survey-creator-core/src/components/question.scss
@@ -758,15 +758,15 @@ svc-question,
   .svc-carry-forward-panel {
     margin-top: calcSize(2);
   }
+}
 
-  .sd-question__content {
+.svc-question__content>.sd-question>.sd-question__content {
     min-width: min(calcSize(8), 100%);
     margin-left: calcSize(-5);
     margin-right: calcSize(-5);
     padding-left: calcSize(5);
     padding-right: calcSize(5);
     overflow-x: auto;
-  }
 }
 
 .svc-question__content--ranking {

diff --git a/visualRegressionTests/tests/designer/etalons/composite-question-no-scroll.png b/visualRegressionTests/tests/designer/etalons/composite-question-no-scroll.png
diff --git a/visualRegressionTests/tests/designer/surface.ts b/visualRegressionTests/tests/designer/surface.ts
@@ -1921,4 +1921,48 @@ test("Check minimal height", async (t) => {
     })();
     await takeElementScreenshot("creator-min-height.png", root, t, comparer);
   });
+});
+
+test("Composite question - no scroll", async (t) => {
+  await wrapVisualTest(t, async (t, comparer) => {
+    await ClientFunction(() => {
+      window["Survey"].ComponentCollection.Instance.add({
+        name: "fullname",
+        title: "Full Name",
+        elementsJSON: [
+          {
+            type: "text",
+            name: "firstName",
+            title: "First Name",
+            isRequired: true,
+            minWidth: 200
+          },
+          {
+            type: "text",
+            name: "lastName",
+            title: "Last Name",
+            isRequired: true,
+            minWidth: 200,
+            startWithNewLine: false,
+          }
+        ],
+      });
+    })();
+    await t.resizeWindow(1120, 900);
+    await setJSON({
+      "pages": [
+        {
+          "name": "page1",
+          "elements": [
+            {
+              "type": "fullname",
+              "name": "question1"
+            }
+          ]
+        }
+      ]
+    });
+    await t.hover(".sd-input.sd-text");
+    await takeElementScreenshot("composite-question-no-scroll.png", Selector(".svc-question__adorner"), t, comparer);
+  });
 });