An exception raise on making Creator read-only when onMachineTranslat…

…e event is used fix #5319 (#5320)
surveyjs · Mar 12, 2024 · 88ad8ca · 88ad8ca
1 parent 7af4c6f
commit 88ad8ca
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 8 deletions.
diff --git a/packages/survey-creator-core/src/components/tabs/translation.ts b/packages/survey-creator-core/src/components/tabs/translation.ts
@@ -729,16 +729,19 @@ export class Translation extends Base implements ITranslationLocales {
     });
     res.onGetMatrixRowActions.add((sender, options) => {
       updateMatrixRemoveAction(options.question, options.actions, options.row);
-      if (this.options.getHasMachineTranslation() && findAction(options.actions, "remove-row")) {
+      if (this.options.getHasMachineTranslation() && findAction(options.actions, "remove-row") &&
+        Array.isArray(options.question.value)) {
         const q = options.question;
         const rowIndex = q.visibleRows.indexOf(options.row);
-        const locale = q.value[rowIndex].name;
-        options.actions.splice(0, 0, new Action({
-          iconName: "icon-language",
-          locTooltipName: "ed.translateUsigAI",
-          location: "end",
-          action: () => this.showTranslationEditor(locale)
-        }));
+        if(rowIndex >= 0 && rowIndex < q.value.length) {
+          const locale = q.value[rowIndex].name;
+          options.actions.splice(0, 0, new Action({
+            iconName: "icon-language",
+            locTooltipName: "ed.translateUsigAI",
+            location: "end",
+            action: () => this.showTranslationEditor(locale)
+          }));
+        }
       }
       updateMatixActionsClasses(options.actions);
     });

diff --git a/packages/survey-creator-core/tests/tabs/translation.tests.ts b/packages/survey-creator-core/tests/tabs/translation.tests.ts
@@ -1930,3 +1930,27 @@ test("If panel title then don't include it for 'Use string only' mode, Bug #5236
   translation.reset();
   expect(translation.root.allLocItems).toHaveLength(2);
 });
+test("Translation: readOnly & onMachineTranslate", () => {
+  let creator = new CreatorTester({ showTranslationTab: true });
+  creator.onActiveTabChanging.add((sender, options) => {
+    creator.readOnly = options.tabName !== "translation";
+  });
+  creator.onMachineTranslate.add((sender, options) => {});
+  creator.JSON = {
+    pages: [
+      {
+        name: "page2",
+        title: "Page title"
+      }
+    ]
+  };
+  creator.activeTab = "translation";
+  expect(creator.readOnly).toBeFalsy();
+  const tabTranslationPlugin: TabTranslationPlugin = creator.getPlugin("translation");
+  const translation = tabTranslationPlugin.model;
+  expect(translation.localesQuestion.visibleRows).toHaveLength(1);
+  translation.addLocale("de");
+  expect(translation.localesQuestion.visibleRows).toHaveLength(2);
+  creator.activeTab = "designer";
+  expect(creator.readOnly).toBeTruthy();
+});