Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2: Theming of choices popup does not work correctly #2669

Closed
Akkora opened this issue Feb 10, 2022 · 4 comments
Closed

V2: Theming of choices popup does not work correctly #2669

Akkora opened this issue Feb 10, 2022 · 4 comments
Assignees
Labels
Milestone

Comments

@Akkora
Copy link

Akkora commented Feb 10, 2022

Are you requesting a feature, reporting a bug or ask a question?

bug

What is the current behavior?

When theming the creator, the colors are not applied to the choices popup. It seems that there the variables aren't used. In the screenshot you can see, that the cancel and apply buttons don't have the lightgreen color, but stay in their default color.
image

What is the expected behavior?

Custom colors are applied to the cancel and apply buttons aswell

How would you reproduce the current behavior (if this is a bug)?

  1. Go to the test page url
  2. Add question with choice (radio group, checkbox, etc)
  3. Open the choices bulk edit modal with this button
    image

Provide the test code and the tested page URL (if applicable)

Tested page URL: https://www.surveyjs.io/Examples/Creator?id=editor-custom-theme-css-vars&platform=KnockoutjsV2&theme=modern#content-result

Specify your

  • browser: Chrome 98
  • editor version: 1.9.10-beta.1
@tsv2013 tsv2013 added this to Incoming in Current sprint progress via automation Feb 10, 2022
@tsv2013
Copy link
Member

tsv2013 commented Feb 10, 2022

It looks like this rule .sv-popup__button.sv-popup__button--apply has hardcoded colors. @dk981234 could you take a look?

@tsv2013 tsv2013 added the bug label Feb 11, 2022
@tsv2013 tsv2013 moved this from Incoming to TODO in Current sprint progress Feb 11, 2022
@tsv2013 tsv2013 moved this from TODO to To Do Sprint in Current sprint progress Feb 14, 2022
@tsv2013 tsv2013 added the V2 label Feb 16, 2022
@tsv2013 tsv2013 added this to the v1.9.14 milestone Feb 16, 2022
@tsv2013 tsv2013 self-assigned this Feb 16, 2022
@tsv2013 tsv2013 moved this from To Do Sprint to In Progress in Current sprint progress Feb 16, 2022
@tsv2013 tsv2013 moved this from In Progress to Waiting for... in Current sprint progress Feb 16, 2022
dmitry-kurmanov added a commit to surveyjs/survey-library that referenced this issue Feb 16, 2022
Fixed surveyjs/survey-creator#2669 - V2: Theming of choices popup does not work correctly
Current sprint progress automation moved this from Waiting for... to v1.9.14 Feb 16, 2022
@Akkora
Copy link
Author

Akkora commented Feb 18, 2022

Seems to be still broken in 1.9.14.
I tried in ReactjsV2 and KnockoutjsV2: https://www.surveyjs.io/Examples/Creator?id=editor-custom-theme-css-vars&platform=KnockoutjsV2&theme=modern

image

@Akkora
Copy link
Author

Akkora commented Feb 18, 2022

Additional styling of popup is missing. Since we added the variable additional to the .sv-popup the theming is applied to the border and canceln button. Just the background of the apply button is still in the wrong color.

image

@tsv2013
Copy link
Member

tsv2013 commented Feb 20, 2022

CSS variables should be declared on the body level. Here is the plunker example - https://plnkr.co/edit/CHu15l7ZkBAYtyGt
We'll update the example on our site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants