Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a capability to remove a logo from the design surface #4068

Closed
JaneSjs opened this issue May 2, 2023 · 1 comment · Fixed by #4149
Closed

Add a capability to remove a logo from the design surface #4068

JaneSjs opened this issue May 2, 2023 · 1 comment · Fixed by #4149
Assignees
@mikeamelin @dk981234
Labels
enhancement user issue An issue or bug reported by users.
Milestone
v1.9.89

Comments

@JaneSjs
Copy link
Contributor

JaneSjs commented May 2, 2023

Original issue: T12847 - Survejs V2 migration - Logo in survey title - Remove
https://surveyjs.answerdesk.io/internal/ticket/details/T12847

Survey Creator V1 has a delete logo option in a design surface:
image

However, Survey Creator V2 doesn't:
image

It is possible to only remove a logo in a Property Grid.

Suggestion: add an option to remove a logo to the survey creator design surface.
@JaneSjs JaneSjs added enhancement user issue An issue or bug reported by users. labels May 2, 2023
@JaneSjs JaneSjs changed the title Add a removec logo option to the design surface Add a remove logo option to the design surface May 2, 2023
@mikeamelin
Copy link

https://www.figma.com/file/7QOeoDDCaPuqzWAROR0kDY/Creator?type=design&node-id=18175-396328

dk981234 added a commit that referenced this issue May 22, 2023
@dk981234
Work for #4068: Implement logo context buttons in React. Remove style…
0f880c5 
…s duplication
dk981234 added a commit that referenced this issue May 22, 2023
@dk981234
Work for #4068: apply changes in Knockout
6a6a2ce
dk981234 added a commit that referenced this issue May 22, 2023
@dk981234
Work for #4068: apply changes in Angular
ecece69
dk981234 added a commit that referenced this issue May 22, 2023
@dk981234
Work for #4068: hide context buttons if editing is not allowed
4a0fc17
@dk981234 dk981234 linked a pull request May 22, 2023 that will close this issue
Implement context buttons (load and remove) for survey's logo #4149
Merged
tsv2013 pushed a commit that referenced this issue May 23, 2023
@dk981234
Implement context buttons (load and remove) for survey's logo (#4149)
4842b6d 
* Work for #4068: Implement logo context buttons in React. Remove styles duplication

* Work for #4068: apply changes in Knockout

* Work for #4068: apply changes in Angular

* Work for #4068: hide context buttons if editing is not allowed

* Fix vrt tests

* Fix f tests
@RomanTsukanov RomanTsukanov changed the title Add a remove logo option to the design surface Add a capability to remove a logo from the design surface May 23, 2023
@OlgaLarina OlgaLarina added this to the v1.9.89 milestone May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikeamelin mikeamelin

@dk981234 dk981234

Labels
enhancement user issue An issue or bug reported by users.
Projects
None yet
Milestone
v1.9.89
Development

Successfully merging a pull request may close this issue.

Implement context buttons (load and remove) for survey's logo surveyjs/survey-creator
4 participants
@OlgaLarina @mikeamelin @dk981234 @JaneSjs