Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Progress bar alignment" property is not localized #5433

Closed
Matvey1308 opened this issue Apr 23, 2024 · 0 comments · Fixed by #5435
Closed

"Progress bar alignment" property is not localized #5433

Matvey1308 opened this issue Apr 23, 2024 · 0 comments · Fixed by #5435
Assignees
Labels
bug user issue An issue or bug reported by users.
Milestone

Comments

@Matvey1308
Copy link

Matvey1308 commented Apr 23, 2024

Are you requesting a feature, reporting a bug or ask a question?

Bug

What is the current behavior?

Survey properties -> Navigation -> Progress bar alignment dropdown

There is an issue when user chose the Progress bar alignment dropdown's value, such as 'Above the header', 'Below the header' or 'Top and bottom'.

If user choose one of these three values and application triggers some logic which could provide some updates of the survey object, it would cause resetting the dropdown's label from 'Above the header' to 'Select...'

But if user choose one of the others options, such as 'Auto', 'Hidden' or 'Bottom' and application triggers same logic which could provide some updates of the survey object, the dropdown would have a proper label -> 'Auto', 'Hidden' or 'Bottom'

What is the expected behavior?

User should choose any value in dropdown and it should keep the proper label.

How would you reproduce the current behavior (if this is a bug)?

In this simple code you could consider the bug

https://codesandbox.io/p/sandbox/charming-wu-566tpl

Steps to reproduce:

  1. Go to survey properties.
  2. Open navigation tab
  3. Find a Progress bar alignment dropdown
  4. Choose 'Auto' option
  5. Open survey properties -> navigation again
  6. You would see the 'Auto' label in Progress bar alignment dropdown

after this

  1. Go to survey properties.
  2. Open navigation tab
  3. Find a Progress bar alignment dropdown
  4. Choose 'Above the header' option
  5. Open survey properties -> navigation again
  6. You would see the 'Select...' label in Progress bar alignment dropdown, but in JSON Editor tab there would be a "showProgressBar": "aboveheader" property

bug

@andrewtelnov andrewtelnov added bug user issue An issue or bug reported by users. labels Apr 23, 2024
@tsv2013 tsv2013 self-assigned this Apr 24, 2024
tsv2013 pushed a commit to surveyjs/survey-library that referenced this issue Apr 25, 2024
…our of the 'Progress bar alignment' dropdown
tsv2013 pushed a commit that referenced this issue Apr 25, 2024
andrewtelnov added a commit to surveyjs/survey-library that referenced this issue Apr 26, 2024
Work for surveyjs/survey-creator#5433 - [Survey creator] Weird behaviour of the 'Progress bar alignment' dropdown
novikov82 pushed a commit that referenced this issue Apr 26, 2024
…lignment' dropdown (#5435)

Co-authored-by: tsv2013 <tsv2013@noreply.github.com>
@RomanTsukanov RomanTsukanov changed the title [Survey creator] Weird behaviour of the 'Progress bar alignment' dropdown "Progress bar alignment" property is not localized Apr 30, 2024
@OlgaLarina OlgaLarina added this to the v1.10.2 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug user issue An issue or bug reported by users.
Projects
None yet
4 participants