Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: The onDragStart and onDragEnd events do not have parameter descriptions in the docs #5528

Merged
merged 4 commits into from
Jun 12, 2024
Merged

PR: The onDragStart and onDragEnd events do not have parameter descriptions in the docs #5528

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
89883c0
work for the https://github.com/surveyjs/survey-creator/issues/5478
dmitry-kurmanov May 23, 2024
4d8149a
Merge branch 'master' into bug/5478-ondragstart-doc-issue
dmitry-kurmanov Jun 11, 2024
aadc5b9
work for the https://github.com/surveyjs/survey-creator/issues/5478
dmitry-kurmanov Jun 11, 2024
e891061
Merge branch 'master' into bug/5478-ondragstart-doc-issue
dmitry-kurmanov Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/survey-creator-core/src/creator-base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1754,14 +1754,14 @@ export class SurveyCreatorModel extends Base
* @see onDragEnd
* @see onDragDropAllow
*/
public onDragStart: EventBase<any, DragStartEndEvent> = new EventBase<any, DragStartEndEvent>();
public onDragStart: EventBase<any, DragStartEndEvent> = this.addCreatorEvent<any, DragStartEndEvent>();
public onBeforeDrop: EventBase<any, DragStartEndEvent> = this.onDragStart;
/**
* An event that is raised when users finish dragging a survey element within the design surface.
* @see onDragStart
* @see onDragDropAllow
*/
public onDragEnd: EventBase<any, DragStartEndEvent> = new EventBase<any, DragStartEndEvent>();
public onDragEnd: EventBase<any, DragStartEndEvent> = this.addCreatorEvent<any, DragStartEndEvent>();
public onAfterDrop: EventBase<any, DragStartEndEvent> = this.onDragEnd;
private initDragDropSurveyElements() {
DragDropSurveyElements.restrictDragQuestionBetweenPages =
Expand Down
Loading