Resolved Work for surveyjs/survey-creator#1606 - fixed rendering inv…

…isible row becomes visible
surveyjs · Aug 10, 2021 · 93b5990 · 93b5990
1 parent ff595c3
commit 93b5990
Show file tree

Hide file tree

Showing 2 changed files with 55 additions and 1 deletion.
diff --git a/src/panel.ts b/src/panel.ts
@@ -1033,6 +1033,9 @@ export class PanelModelBase extends SurveyElement
       var row = rows[i];
       if (row.elements.indexOf(element) > -1) {
         row.updateVisible();
+        if(row.visible && !row.isNeedRender) {
+          row.isNeedRender = true;
+        }
         break;
       }
     }

diff --git a/tests/paneltests.ts b/tests/paneltests.ts
@@ -1522,4 +1522,55 @@ QUnit.test(
       settings.lazyRowsRendering = prevLazyRowsRendering;
       settings.lazyRowsRenderingStartRow = prevStartRowInLazyRendering;
     }
-});
+});
+
+QUnit.test(
+  "row.isNeedRender for question invisible -> visible",
+  function(assert) {
+    var json = {
+      pages: [
+        {
+          name: "page1",
+          elements: [
+            {
+              type: "text",
+              name: "q1",
+            },
+            {
+              type: "text",
+              name: "q2",
+            },
+            {
+              type: "text",
+              name: "q3",
+              visibleIf: "{q1} == 'a'"
+            },
+          ],
+        }
+      ],
+    };
+
+    const prevLazyRowsRendering = settings.lazyRowsRendering;
+    const prevStartRowInLazyRendering = settings.lazyRowsRenderingStartRow;
+    settings.lazyRowsRenderingStartRow = 2;
+    try {
+      var survey = new SurveyModel(json);
+      survey.lazyRendering = true;
+      const page1: PageModel = survey.pages[0];
+      page1.setWasShown(false);
+      page1.onFirstRendering();
+      assert.equal(page1.rows.length, 3, "There are 3 rows");
+      assert.equal(page1.rows[0].isNeedRender, true, "isNeedRender rows[0]");
+      assert.equal(page1.rows[1].isNeedRender, true, "isNeedRender rows[1]");
+      assert.equal(page1.rows[2].isNeedRender, false, "isNeedRender rows[2]");
+
+      survey.data = { q1: "a" };
+
+      assert.equal(page1.rows[2].isNeedRender, true, "isNeedRender rows[2]");
+
+    } finally {
+      settings.lazyRowsRendering = prevLazyRowsRendering;
+      settings.lazyRowsRenderingStartRow = prevStartRowInLazyRendering;
+    }
+  }
+);