resolve #6492 "Select..." is rendered together with the value in drop…

…down
surveyjs · Jul 10, 2023 · c869fe0 · c869fe0
1 parent 21c07a5
commit c869fe0
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 1 deletion.
diff --git a/src/question_dropdown.ts b/src/question_dropdown.ts
@@ -39,7 +39,7 @@ export class QuestionDropdownModel extends QuestionSelectBase {
     this.registerPropertyChangedHandlers(["choicesMin", "choicesMax", "choicesStep"], () => {
       this.onVisibleChoicesChanged();
     });
-    this.registerPropertyChangedHandlers(["value", "renderAs", "showOtherItem", "otherText", "placeholder", "choices"], () => {
+    this.registerPropertyChangedHandlers(["value", "renderAs", "showOtherItem", "otherText", "placeholder", "choices", "visibleChoices"], () => {
       this.updateReadOnlyText();
     });
     this.updateReadOnlyText();

diff --git a/tests/questionDropdownTests.ts b/tests/questionDropdownTests.ts
@@ -356,6 +356,42 @@ QUnit.test("readOnlyText default", assert => {
   question.value = 2;
   assert.equal(question.readOnlyText, "", "use choice text");
 });
+QUnit.test("readOnlyText visibleChoices changed", assert => {
+  const json = {
+    "pages": [
+      {
+        "name": "page1",
+        "elements": [
+          {
+            "type": "dropdown",
+            "name": "q1",
+            "choices": [
+              "Item 1",
+              "Item 2",
+              "Item 3"
+            ]
+          },
+          {
+            "type": "dropdown",
+            "name": "q2",
+            "choices": [
+              "Item 1",
+              "Item 2",
+              "Item 3"
+            ],
+            "choicesVisibleIf": "{q1} = 'Item 1'"
+          }
+        ]
+      }
+    ],
+  };
+  const survey = new SurveyModel(json);
+  survey.data = { "q1": "Item 1", "q2": "Item 1" };
+
+  const q2 = <QuestionDropdownModel>survey.getQuestionByName("q2");
+  assert.equal(q2.readOnlyText, "");
+  assert.equal(q2.selectedItem.id, "Item 1");
+});
 QUnit.test("readOnlyText render as select", assert => {
   const json = {
     questions: [