Fix: onCompleting event doesn't work on "complete" trigger #3184 (#3185)

surveyjs · Aug 10, 2021 · f1065a0 · f1065a0
1 parent 93b5990
commit f1065a0
Show file tree

Hide file tree

Showing 2 changed files with 52 additions and 1 deletion.
diff --git a/src/survey.ts b/src/survey.ts
@@ -3558,7 +3558,10 @@ export class SurveyModel extends Base
       isCompleteOnTrigger: isCompleteOnTrigger,
     };
     this.onCompleting.fire(this, onCompletingOptions);
-    if (!onCompletingOptions.allowComplete) return false;
+    if (!onCompletingOptions.allowComplete) {
+      this.isCompleted = false;
+      return false;
+    }
     let previousCookie = this.hasCookie;
     this.stopTimer();
     this.setCompleted();

diff --git a/tests/surveytests.ts b/tests/surveytests.ts
@@ -7475,6 +7475,54 @@ QUnit.test("Compete trigger with invisible question, #2, Bug #2098", function(
   survey.nextPage();
   assert.equal(survey.state, "completed", "Survey is completed");
 });
+QUnit.test("Compete trigger and allowComplete false, Bug #3184", function(
+  assert
+) {
+  var json = {
+    pages: [
+      {
+        elements: [
+          {
+            type: "text",
+            name: "age",
+            inputType: "number",
+          },
+        ],
+      },
+      {
+        elements: [
+          {
+            type: "text",
+            name: "question1",
+          },
+        ],
+      },
+      {
+        elements: [
+          {
+            type: "text",
+            name: "question2",
+          },
+        ],
+      },
+    ],
+    triggers: [
+      {
+        type: "complete",
+        expression: "{age}<18",
+      },
+    ],
+  };
+  var survey = new SurveyModel(json);
+  survey.onCompleting.add((sender, options) => {
+    options.allowComplete = false;
+  });
+  survey.getQuestionByName("age").value = 10;
+  assert.equal(survey.currentPageNo, 0);
+  survey.nextPage();
+  assert.equal(survey.state, "running", "Survey is not completed");
+  assert.equal(survey.currentPageNo, 0, "stay on the same page");
+});
 
 QUnit.test("textUpdateMode=onTyping and goNextPageAutomatic option", function(
   assert