Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expession: No errors should be thrown even if an expression cannot be parsed #5384

Closed
novikov82 opened this issue Dec 20, 2022 · 1 comment · Fixed by #7058
Closed

Expession: No errors should be thrown even if an expression cannot be parsed #5384

novikov82 opened this issue Dec 20, 2022 · 1 comment · Fixed by #7058
Assignees
@andrewtelnov
Labels
enhancement
Milestone
v1.9.111

Comments

@novikov82
Copy link
Contributor

novikov82 commented Dec 20, 2022 •
edited
Loading

if expression is wrong it returns empty string
if expression refers question with unknown name it returns 0
if question refers to unregistered function it returns...

We do not raise any exception in that cases. It is ok.
But we need to show some warning in console.
@novikov82 novikov82 added the bug label Dec 20, 2022
@novikov82 novikov82 changed the title Expession: no errors if cannot be parsed, just zero in value Expession: no errors if cannot be parsed Dec 20, 2022
@tsv2013 tsv2013 added enhancement and removed bug labels Jan 10, 2023
@OlgaLarina OlgaLarina added this to the v1.9.69 milestone Jan 10, 2023
@OlgaLarina OlgaLarina modified the milestones: v1.9.69, v1.9.70 Jan 18, 2023
@JaneSjs
Copy link
Contributor

JaneSjs commented Jan 18, 2023

+1 T11797 - Error in Expression or Calculated Value (e.replace is not a function)

@JaneSjs JaneSjs changed the title Expession: no errors if cannot be parsed Expession: No errors should be thrown even if an expression cannot be parsed Jan 18, 2023
@OlgaLarina OlgaLarina modified the milestones: v1.9.70, v1.9.71 Jan 26, 2023
@OlgaLarina OlgaLarina modified the milestones: v1.9.71, v1.9.72, v1.9.73 Feb 6, 2023
@OlgaLarina OlgaLarina modified the milestones: v1.9.73, v1.9.75, v1.9.76 Feb 16, 2023
@OlgaLarina OlgaLarina modified the milestones: v1.9.76, v1.9.77 Feb 28, 2023
@OlgaLarina OlgaLarina modified the milestones: v1.9.77, v1.9.78 Mar 9, 2023
andrewtelnov added a commit that referenced this issue Oct 1, 2023
@andrewtelnov
Expession: No errors should be thrown even if an expression cannot be…
0ed9967 
… parsed fix #5384
@andrewtelnov andrewtelnov mentioned this issue Oct 1, 2023
Merged
tsv2013 pushed a commit that referenced this issue Oct 2, 2023
@andrewtelnov
Expession: No errors should be thrown even if an expression cannot be…
797d7e1 
… parsed fix #5384 (#7058)
@OlgaLarina OlgaLarina added this to the v1.9.111 milestone Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewtelnov andrewtelnov

Labels
enhancement
Projects
None yet
Milestone
v1.9.111
Development

Successfully merging a pull request may close this issue.

Expession: No errors should be thrown even if an expression cannot be… surveyjs/survey-library
5 participants
@tsv2013 @andrewtelnov @OlgaLarina @JaneSjs @novikov82