Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Margin to Padding Conversion Needed in defaultv2 Theme (SurveyJS - jQuery) #6571

Closed
PerikiyoXD opened this issue Jul 23, 2023 · 1 comment
Closed
Assignees
Milestone

Comments

@PerikiyoXD
Copy link

PerikiyoXD commented Jul 23, 2023

Are you requesting a feature, reporting a bug or asking a question?

Bug report

What is the current behavior?

Using defaultv2 theme, there's an extra margin below the content, which may be mistakenly assigned as margin where it should be padding. (The white area in the border)
imagen
imagen

What is the expected behavior?

Swap the margin to padding, fixing the issue.
imagen
imagen

How would you reproduce the current behavior (if this is a bug)?

Rendered CSS on the browser:

.sd-container-modern {
  margin-bottom: calc(10 * var(--sjs-base-unit, var(--base-unit, 8px)));
}

Swap "margin" to "padding"

Provide the test code and the tested page URL (if applicable)

Tested page URL:
https://stackblitz.com/edit/js-k5f3t1?file=index.html
Test code
Check code @ stackblitz link

Specify your

  • browser: Firefox
  • browser version: 115.0.2 (64-bit)
  • surveyjs platform (angular or react or jquery or knockout or vue): jquery (may affect other platforms too)
  • surveyjs version: 1.9.98
@PerikiyoXD
Copy link
Author

PerikiyoXD commented Jul 23, 2023

Any feedback on the matter will be appreciated, let's discuss if this is an intended or unintended behaviour.

@tsv2013 tsv2013 self-assigned this Jul 24, 2023
tsv2013 added a commit that referenced this issue Jul 24, 2023
@tsv2013 tsv2013 closed this as completed in 284b546 Aug 9, 2023
@OlgaLarina OlgaLarina added this to the v1.9.103 milestone Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants