Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Survey margins. #6243

Closed
mikeamelin opened this issue May 24, 2023 · 1 comment
Closed

Survey margins. #6243

mikeamelin opened this issue May 24, 2023 · 1 comment
Assignees
@tsv2013 @mikeamelin
Labels
enhancement theme builder website demos
Milestone
v1.9.103

Comments

@mikeamelin
Copy link

mikeamelin commented May 24, 2023 •
edited
Loading

Different magrins for the responsive mode.

Important — pay attention to all cases.
— title on/off
— description on/off
— panels/lightweight

https://www.figma.com/file/jcuAUsN02n2yJerx39mqf9/Previews?type=design&node-id=101-8&mode=dev
@mikeamelin mikeamelin self-assigned this May 24, 2023
@tsv2013 tsv2013 self-assigned this Jun 2, 2023
tsv2013 added a commit that referenced this issue Jul 24, 2023
@tsv2013
Resolved #6243 - Survey margins + fixed #6571
f21ef39
@mikeamelin
Copy link
Author

  • static mode — top margin must be 48 px instead 40 px (which uses for responsive mode)
    Screenshot 2023-07-27 at 14 35 08

  • in case when survey width is smaller then the default width (but not the mobile mode) we must use responsive margins
    Screenshot 2023-07-27 at 14 41 35

  • in case of mobile view for responsive mode the margins must be 24px

Screenshot 2023-07-27 at 14 40 12

  • in case of mobile view for static mode the margins must be 24px
    Screenshot 2023-07-27 at 14 41 14

tsv2013 added a commit that referenced this issue Aug 2, 2023
@tsv2013
Work for #6243 - Survey margins - updated etalons
921ae7c
tsv2013 added a commit that referenced this issue Aug 2, 2023
@tsv2013
Work for #6243 - Survey margins - updated etalons
fa73b92
OlgaLarina pushed a commit that referenced this issue Aug 2, 2023
work for #6243 Survey margins. - fix f-tests
f259187
tsv2013 added a commit that referenced this issue Aug 3, 2023
@tsv2013
work for #6243 Survey margins. - updated etalons
5dc5579
tsv2013 added a commit to surveyjs/survey-creator that referenced this issue Aug 3, 2023
@tsv2013
Work for surveyjs/survey-library#6243 - fixed layout in creator
64fbc9c
tsv2013 added a commit that referenced this issue Aug 4, 2023
@tsv2013
Work for #6243 Survey margins - fixed remarks
cdd724d
tsv2013 added a commit that referenced this issue Aug 4, 2023
@tsv2013
Work for #6243 Survey margins - fixed remarks - try to keep width
16db994
tsv2013 added a commit that referenced this issue Aug 4, 2023
@tsv2013
Work for #6243 Survey margins - updated etalons
4aed99a
tsv2013 added a commit that referenced this issue Aug 4, 2023
@tsv2013
Work for #6243 Survey margins - fix constants in tests
72041c9
tsv2013 added a commit that referenced this issue Aug 4, 2023
@tsv2013
Work for #6243 Survey margins - fix constants in tests
00c8b43
tsv2013 added a commit that referenced this issue Aug 4, 2023
@tsv2013
Work for #6243 Survey margins - fix constants in tests
d1e83e9
tsv2013 added a commit that referenced this issue Aug 7, 2023
@tsv2013
Work for #6243 Survey margins - fix panel top margin
44d67e8
tsv2013 added a commit that referenced this issue Aug 7, 2023
@tsv2013
Work for #6243 Survey margins - updated etalons
dbd238b
tsv2013 added a commit that referenced this issue Aug 7, 2023
@tsv2013
Work for #6243 Survey margins - updated etalons
0c1e313
tsv2013 added a commit that referenced this issue Aug 7, 2023
@tsv2013
Work for #6243 Survey margins - updated etalons
e0cb75e
tsv2013 added a commit that referenced this issue Aug 7, 2023
@tsv2013
Work for #6243 Survey margins - updated etalons
efe787d
tsv2013 added a commit that referenced this issue Aug 7, 2023
@tsv2013
Work for #6243 Survey margins - fix row top margin in Angular
f9794cc
tsv2013 added a commit that referenced this issue Aug 7, 2023
@tsv2013
Work for #6243 Survey margins - body box sizing
f7b0d97
tsv2013 added a commit that referenced this issue Aug 7, 2023
@tsv2013
Work for #6243 Survey margins - fix row top margin in Angular
f16a70a
tsv2013 added a commit that referenced this issue Aug 7, 2023
@tsv2013
Work for #6243 Survey margins - updated etalons
f02e749
tsv2013 added a commit that referenced this issue Aug 7, 2023
@tsv2013
Work for #6243 Survey margins - fix row top margin in Angular - revert
cb82564
tsv2013 added a commit that referenced this issue Aug 7, 2023
@tsv2013
Work for #6243 Survey margins - updated etalons
e76f487
tsv2013 added a commit that referenced this issue Aug 7, 2023
@tsv2013
Work for #6243 Survey margins - updated etalons
a96e404
tsv2013 added a commit that referenced this issue Aug 8, 2023
@tsv2013
Work for #6243 Survey margins - fix responsive mode
7febdc6
tsv2013 added a commit that referenced this issue Aug 8, 2023
@tsv2013
Work for #6243 Survey margins - updated etalons
ee57342
tsv2013 added a commit that referenced this issue Aug 8, 2023
@tsv2013
Work for #6243 Survey margins - fix row top margin in Angular
0fad209
andrewtelnov pushed a commit to surveyjs/survey-creator that referenced this issue Aug 8, 2023
@tsv2013
Work for surveyjs/survey-library#6243 - fixed layout in creator (#4421)
cacdfe5
tsv2013 added a commit that referenced this issue Aug 8, 2023
@tsv2013
Work for #6243 Survey margins - fix row top margin in Angular
11fc091
tsv2013 added a commit that referenced this issue Aug 8, 2023
@tsv2013
Work for #6243 Survey margins - fix row top margin
ed1c819
tsv2013 added a commit that referenced this issue Aug 8, 2023
@tsv2013
Work for #6243 Survey margins - fix row top margin
6c6df72
@tsv2013 tsv2013 closed this as completed in 284b546 Aug 9, 2023
@OlgaLarina OlgaLarina added this to the v1.9.103 milestone Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsv2013 tsv2013

@mikeamelin mikeamelin

Labels
enhancement theme builder website demos
Projects
None yet
Milestone
v1.9.103
Development

No branches or pull requests
3 participants
@tsv2013 @OlgaLarina @mikeamelin