Do not use JSON stringify/parse functions in Helpers.getUnbindValue f…

[andrewtelnov]

…ix #6478

[salargl]

Hey @andrewtelnov thanks for the fix. But I wonder what this function tries to achieve? and what happens if we just return the value when it is an instance of Array e.g.:

public static getUnbindValue(value: any): any {
  if(Array.isArray(value)) {
    return value;
  }
  if (!!value && value instanceof Object && !(value instanceof Date)) {
    const res: any = {};
    const keys = Object.keys(value);
    keys.forEach(key => {
      const val = Helpers.getUnbindValue(value[key]);
      if(val !== undefined) {
        res[key] = val;
      }
    });
    return res;
  }
  return value;
}

[andrewtelnov]

@salargl If you run unit tests with your code then 68 unit tests will be failed.
Here is the reason:

const val = matrixQustion.value;
val.push(newValue); //this line will modify matrixQustion.value becaue the instance is the same.

I had to modify the code to the following to fix unit tests in SurveyJS Creator V1&V2:

  public static getUnbindValue(value: any): any {
    if(Array.isArray(value)) {
      const res = [];
      for(let i = 0; i < value.length; i ++) {
        res.push(Helpers.getUnbindValue(value[i]));
      }
      return res;
    }
    if (!!value && value instanceof Object && !(value instanceof Date)) {
      return JSON.parse(JSON.stringify(value));
    }
    return value;
  }

Thank you,
Andrew