fix: fix removal of * in error message

surveyplanet · Feb 11, 2023 · 248dd8b · 248dd8b
1 parent 6e7f059
commit 248dd8b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/tests/validate.test.ts b/src/tests/validate.test.ts
@@ -373,9 +373,11 @@ describe('Validator', () => {
 				const label = input.nextSibling as HTMLLabelElement;
 
 				expect(label).toBeDefined();
+				console.log(label.textContent);
 				expect(label.textContent).toBe(
 					errors[0].error.replace(/<\/?em>/g, '')
 				);
+
 				expect(label.textContent?.endsWith('*')).toBeFalsy();
 			}
 

diff --git a/src/validate.ts b/src/validate.ts
@@ -544,11 +544,11 @@ export function getInputLabel(input: FormInput): string {
 
 	const placeholderText = input.getAttribute('placeholder');
 
-	if (label?.innerText?.length) {
-		labelText = label.innerText.trim();
+	if (label?.textContent?.length) {
+		labelText = label.textContent.trim();
 
 		if (labelText.length > 1 && labelText.endsWith('*')) {
-			labelText.slice(0, -1);
+			labelText = labelText.replace(/\s?\*$/, '');
 		}
 	} else if (placeholderText?.length) {
 		labelText = placeholderText;