Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mergeUnique array customization does not work properly #161

Closed
trombka opened this issue Dec 7, 2020 · 1 comment · Fixed by #162
Closed

mergeUnique array customization does not work properly #161

trombka opened this issue Dec 7, 2020 · 1 comment · Fixed by #162

Comments

@trombka
Copy link
Contributor

trombka commented Dec 7, 2020

Hi,

The "unique" merge array customisation works only when the second array has the same element in the same place (has the same index).

Just exchange these two lines
https://github.com/survivejs/webpack-merge/blob/develop/test/unique.test.ts#L72,L73
which should not change the result and the test will fail with a duplicated plugin.

@bebraw
Copy link
Member

bebraw commented Dec 7, 2020

Thanks for the report. I'll try to address this in the next pass when I get to work on the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants