Skip to content

Commit

Permalink
added touch events, test for issue 6
Browse files Browse the repository at this point in the history
  • Loading branch information
sustainablepace committed Jul 8, 2012
1 parent 0f1ab65 commit 300c6b8
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 2 deletions.
5 changes: 5 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ Demo
Changelog
---------

### 0.7 ###
* [https://github.com/sustainablepace/mobipick/issues/5](Issue #5)
* new public method updateDateInput
* possible to set date to null

### 0.6 ###
* set minDate/maxDate programmatically

Expand Down
2 changes: 1 addition & 1 deletion js/mobipick.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ $.widget( "sustainablepace.mobipick", $.mobile.widget, {
},
widgetEventPrefix: "mobipick",
// See http://stackoverflow.com/questions/6577346/jquery-bind-all-events-on-object
_blockedEvents: "tap, touchstart, touchmove, blur, focus, focusin, focusout, load, resize, scroll, unload, click, dblclick, mousedown, mouseup, mousemove, mouseover, mouseout, mouseenter, mouseleave, change, select, submit, keydown, keypress, keyup, error",
_blockedEvents: "tap, touchstart, touchmove, touchend, touchcancel, blur, focus, focusin, focusout, load, resize, scroll, unload, click, dblclick, mousedown, mouseup, mousemove, mouseover, mouseout, mouseenter, mouseleave, change, select, submit, keydown, keypress, keyup, error",
_markup: "<div class='mobipick-click-layer mobipick-overlay'></div><div class='mobipick-main-layer mobipick-overlay'><div class='mobipick-main'><div class='mobipick-date-formatted'>Date</div><ul class='mobipick-groups'><li><ul><li><a class='mobipick-next-day'>+</a></li><li><input type='text' class='mobipick-input mobipick-day' /></li><li><a class='mobipick-prev-day'>-</a></li></ul></li><li><ul><li><a class='mobipick-next-month'>+</a></li><li><input type='text' class='mobipick-input mobipick-month' /></li><li><a class='mobipick-prev-month'>-</a></li></ul></li><li><ul><li><a class='mobipick-next-year'>+</a></li><li><input type='text' class='mobipick-input mobipick-year' /></li><li><a class='mobipick-prev-year'>-</a></li></ul></li></ul><ul class='mobipick-buttons'><li><a class='mobipick-set'>Set</a></li><li><a class='mobipick-cancel'>Cancel</a></li></ul></div></div>",

// Controller
Expand Down
3 changes: 2 additions & 1 deletion tests/tests.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<title>Mobi Pick - QUnit Test Suite</title>
<link rel="stylesheet" href="../external/qunit.css" type="text/css" media="screen">
<link rel="stylesheet" href="../css/mobipick.css" />
<link rel="stylesheet" href="../external/jquery.mobile-1.0.min.css" />
<script type="text/javascript" src="../external/qunit.js"></script>
<script type="text/javascript" src="../external/jquery-1.6.4.min.js"></script>
<script type="text/javascript" src="../external/jquery.mobile-1.0.js"></script>
Expand All @@ -18,7 +19,7 @@ <h2 id="qunit-banner"></h2>
<div id="qunit-testrunner-toolbar"></div>
<h2 id="qunit-userAgent"></h2>
<ol id="qunit-tests"></ol>
<input id="mobipick" type="date" />
<input id="mobipick" type="text" />
</body>
</html>

18 changes: 18 additions & 0 deletions tests/tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -303,3 +303,21 @@ test( "Reinitialize", function() {
var date = p.mobipick("option", "date");
same( date, null);
});
test("Issue 6", function() {
var i = 0;
var button = $("<button></button>").text("Large button").css({
width: "1000px",
height: "1000px"
}).bind("tap", function() {
i++;
alert("!");
});
$("#qunit-tests").after(button);
$(window).scrollTop(10000);

this.$mp.mobipick().trigger( "tap" );
this.selectDatepickerItems();
this.$nextDay.trigger( "tap" );

same(i, 0);
});

0 comments on commit 300c6b8

Please sign in to comment.