Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read elements with VR=UN and undefined VL as SQ #331

Merged
merged 4 commits into from
Jun 9, 2024
Merged

Conversation

suyashkumar
Copy link
Owner

@suyashkumar suyashkumar commented Jun 9, 2024

This addresses #220 (and one of the dicoms in #327) by treating elements with a VR=UN and undefined VL as Sequences.

This pulls from work that I and @jabillings did previously (#235).

Some follow on changes may be needed to support this part of the spec CP:

If at some point an application knows the actual VR for an Attribute of VR UN (e.g. has its own applicable data dictionary), it can assume that the Value Field of the Attribute is encoded in Little Endian byte ordering with implicit VR encoding, irrespective of the current TransferSyntax.

suyashkumar and others added 2 commits June 9, 2024 19:06
---------

Co-authored-by: jabillings <jabillings@users.noreply.github.com>
@suyashkumar suyashkumar marked this pull request as ready for review June 9, 2024 23:12
@suyashkumar suyashkumar merged commit fe2aa28 into main Jun 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant