Fix Unix Socket On Linux #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sv Could you review? |
yznima
force-pushed
the
ffix-unix-linux
branch
2 times, most recently
from
abc7ed8
to
78cfa9c
Compare
sv
requested changes
Oct 3, 2018
kdb.go
Outdated
| func DialUnix(host string, port int, auth string) (*KDBConn, error) { | ||
| c, err := net.Dial("unix", "/tmp/kx."+fmt.Sprint(port)) | ||
| // Connect to port using unix domain sockets. | ||
| func DialUnix(port int, auth string) (*KDBConn, error) { |
There was a problem hiding this comment.
Could you please keep function signature unchanged. I am reviewing api for dialing at the moment and would like to minimise number of changes
kdb.go
Outdated
| } else if runtime.GOOS == "darwin" { | ||
| c, err = net.Dial("unix", fmt.Sprintf("/tmp/kx.%d", port)) | ||
| } else { | ||
| return nil, fmt.Errorf("kdb conn: unix socket is not supported on %s", runtime.GOOS) |
There was a problem hiding this comment.
instead of fmt.Errorf please throw UnknownNetworkError("unix")
like here https://golang.org/src/net/unixsock.go#L59
yznima
force-pushed
the
ffix-unix-linux
branch
2 times, most recently
from
e9acec1
to
5d28cb2
Compare
yznima
force-pushed
the
ffix-unix-linux
branch
from
5d28cb2
to
66df15f
Compare
|
@sv Addressed comments |
sv
approved these changes
Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux, the DialUnix call fails. After investigating further, I realized that kdbq use @/tmp/kx.pid on Linux for Unix socket connection