Nrmlwr fix, fixed issues seen with USRBDX #103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unessessary or obfusciated calls
…filename, which then copies file to dagmc.h5m
…udagwork Conflicts: FluDAG/src/cpp/fluka_funcs.cpp
… earch through all volumes to find volume xyz is in
I am performing my first merge, smoke me a kipper, Ill be back for breakfast.
and reversed sign of the normal vector.
|
Let's review the git part of this on Monday when I'm in the office. |
|
This shouldnt be into master, Ignore this!! |
|
Yes - just realized that too - if a pull request against |
ljacobson64
pushed a commit
to ljacobson64/DAGMC
that referenced
this pull request
Jun 5, 2017
PR svalinn#103: Adding the explicitly created skin entities to the passed non-null meshset. The existing skinner functionality adds the explicitly created skin entities only to the root set without adding the same to any passed meshset. This behaviour is changed in this PR. Now, if a non-null meshset is passed and the skin entities are created, then the new entities would be added to the meshset as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation was incorrect, the fixes here rectify the problems with nrmlwr and solve #100.
Now, this may need some git magic to put right, I believe I have committed my change in the correct place.
I don't believe next_surf was being properly updated and restored based on g1wr, now the logic is
Furthermore, in nrmlwr, Fluka treats senses in the opposite fashion to mcnp
Testing seen in #100 show the issue is rectified.