Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up URL to eliminate double slashes when templating #182

Merged
merged 1 commit into from
Mar 28, 2016

Conversation

danielatdattrixdotcom
Copy link
Contributor

When extracting resource URIs and using them via extraction and tempting an extra leading slash would be added. Also ensures a trailing slash in the URL is retained.

@svanoort-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@svanoort
Copy link
Owner

I like it, looks good to me!

@svanoort svanoort merged commit 65400ce into svanoort:master Mar 28, 2016
@danielatdattrixdotcom danielatdattrixdotcom deleted the coerce-url branch March 28, 2016 23:30
@svanoort
Copy link
Owner

@danielatdattrixdotcom I had to do a quick revert in master, because we both forgot about the scheme prefix for the URL - it will convert http://somewhere.com to http:/somewhere.com - I'll revisit this soon, probably the better solution will involve a little more use of urlparse.

@danielatdattrixdotcom danielatdattrixdotcom restored the coerce-url branch March 31, 2016 00:57
@danielatdattrixdotcom
Copy link
Contributor Author

@svanoort I revised my work and re-created the branch. Can you move this backwards from merged, or do I need to create another?

@svanoort
Copy link
Owner

svanoort commented Apr 9, 2016

@danielatdattrixdotcom Github doesn't really support un-merge / re-merge, unfortunately. I recently had to comment on a (mistakenly marked as merged) PR "This is not actually merged. Go home Github, you're drunk." 😆

So, I'm afraid we'll have to create a new PR for the fixed version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants