Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of mach. #52

Open
wants to merge 1 commit into
base: master
from
Open

Update version of mach. #52

wants to merge 1 commit into from

Conversation

@jdm
Copy link

jdm commented Jan 13, 2020

No description provided.

@jdm

This comment has been minimized.

Copy link
Author

jdm commented Jan 13, 2020

As far as I can tell its types are not exposed through the public API, so this shouldn't require a major version change.

@svartalf

This comment has been minimized.

Copy link
Owner

svartalf commented Jan 13, 2020

Hm, can you rebase from master branch? I forgot to add the CI execution on the PRs for this repo, at least we can do the tests.

Yet, I think I'll not be able to merge it right now, as there is probably the same issue as with #38 (comment); it will bump MSRV and it is probably undesired right now.
Do you have any specific needs to bump the mach version?

@jdm

This comment has been minimized.

Copy link
Author

jdm commented Jan 13, 2020

Only to avoid duplicate dependencies in Servo.

@svartalf

This comment has been minimized.

Copy link
Owner

svartalf commented Jan 13, 2020

@jdm wait, you mean Servo is using/going to use battery? Seems to be a noble reason to publish the new version then :D

@jdm

This comment has been minimized.

Copy link
Author

jdm commented Jan 13, 2020

It's used indirectly through wgpu-core, and we're apparently pulling battery in as part of servo/servo#25507. Duplicating mach isn't a big deal; make the choices that make sense for your primary consumers :)

@svartalf

This comment has been minimized.

Copy link
Owner

svartalf commented Jan 13, 2020

Ah, yes, barely found it: https://github.com/gfx-rs/wgpu/blob/9777bbba361690740c62fd294b968ac6f2340506/wgpu-core/Cargo.toml#L50-L51
For some reasons it is not shown at the "Reverse dependencies" page for the battery crate.

Bumping mach version is a long due task, in fact, I think we can manage it happen; probably by including some additional issues into the next release.
Let's postpone this PR and I'll check what I can do with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.