Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FormValidation to Field.config.schema's type #52

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

esafak
Copy link
Contributor

@esafak esafak commented Sep 28, 2023

Another attempt at fixing #45. I included a component to "test" it in the IDE but I could not write an actual component test. Playwright failed with [vite]: Rollup failed to resolve import "$app/environment", which seems to be related to sveltejs/kit#1485. Here is a repo that contains the test code.

@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2023

🦋 Changeset detected

Latest commit: 51ab7e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
formsnap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
formsnap ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 29, 2023 2:04am

@huntabyte
Copy link
Member

Thank you @esafak !

@huntabyte huntabyte merged commit 09a3854 into svecosystem:main Sep 29, 2023
2 checks passed
@github-actions github-actions bot mentioned this pull request Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants