Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor tweaks (use dist folder, add watch script, update README) #11

Closed
wants to merge 3 commits into from

Conversation

joeattardi
Copy link

This changes the build so that the index.js and index.mjs are placed in a dist subfolder instead of the project root.

Also makes a minor fix to the README which was still referencing index.html instead of index.svelte.

@ghost ghost mentioned this pull request Sep 5, 2019
@akauppi
Copy link

akauppi commented Nov 22, 2019

It also adds build:watch target.

I like using dist/ (or any subfolder) instead of the root. But not quite understanding the src/index.html vs. src/index.svelte issue.

Furthermore, how come there's a PR open since 3 months, at what seems to be the authoritative repo for Svelte? If there are different tiers, those could be marked in the repo description (e.g. [COMMUNITY] or [UNSUPPORTED]).

@Conduitry Conduitry mentioned this pull request Jan 11, 2020
@antony
Copy link
Member

antony commented Nov 11, 2021

Closing this as the bulk of the work has been done in another PR. If we want to add the watch script, as mentioned in the other PR, it should be named dev in line with the rest of the sveltejs org's scripts. I think the idea of adding watch is a good one.

@antony antony closed this Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants