-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adapter-cloudflare doesn't understand kit.paths.base #2843
Labels
bug
Something isn't working
paths.base
bugs relating to `config.kit.paths.base`
pkg:adapter-cloudflare
Milestone
Comments
hmnd
added a commit
to hmnd/svelte-kit
that referenced
this issue
Mar 24, 2022
fixes sveltejs#4442, fixes sveltejs#2843 - add manifest.prefix and builder.getAppPrefixDirectory() - add base path to dest for builder.writeStatic, builder.writeClient, builder.writePrerendered - adapter-cloudflare*: use manifest.prefix instead of manifest.appDir - adapter-netlify: use prefixed appDir for cache headers - adapter-vercel: use prefixed appDir for routes.json - adapter-cloudflare, adapter-cloudflare-workers, adapter-netlify: write static assets to "$dest/$base"
hmnd
added a commit
to hmnd/svelte-kit
that referenced
this issue
Mar 24, 2022
fixes sveltejs#4442, fixes sveltejs#2843 - add manifest.prefix and builder.getAppPrefixDirectory() - adapter-cloudflare*: use manifest.prefix instead of manifest.appDir - adapter-netlify: use prefixed appDir for cache headers - adapter-vercel: use prefixed appDir for routes.json - adapter-cloudflare, adapter-cloudflare-workers, adapter-netlify: write static assets to "$dest/$base"
5 tasks
hmnd
added a commit
to hmnd/svelte-kit
that referenced
this issue
Mar 25, 2022
fixes sveltejs#4442, fixes sveltejs#2843 - add manifest.prefix and builder.getAppPrefixDirectory() - adapter-cloudflare*: use manifest.prefix instead of manifest.appDir - adapter-netlify: use prefixed appDir for cache headers - adapter-vercel: use prefixed appDir for routes.json - adapter-cloudflare, adapter-cloudflare-workers, adapter-netlify: write static assets to "$dest/$base"
hmnd
added a commit
to hmnd/svelte-kit
that referenced
this issue
Mar 25, 2022
fixes sveltejs#4442, fixes sveltejs#2843 - add manifest.prefix and builder.getAppPrefixDirectory() - adapter-cloudflare*: use manifest.prefix instead of manifest.appDir - adapter-netlify: use prefixed appDir for cache headers - adapter-vercel: use prefixed appDir for routes.json - adapter-cloudflare, adapter-cloudflare-workers, adapter-netlify: write static assets to "$dest/$base"
hmnd
added a commit
to hmnd/svelte-kit
that referenced
this issue
Apr 9, 2022
fixes sveltejs#4442, fixes sveltejs#2843 - add manifest.prefix and builder.getAppPrefixDirectory() - adapter-cloudflare*: use manifest.prefix instead of manifest.appDir - adapter-netlify: use prefixed appDir for cache headers - adapter-vercel: use prefixed appDir for routes.json - adapter-cloudflare, adapter-cloudflare-workers, adapter-netlify: write static assets to "$dest/$base"
hmnd
added a commit
to hmnd/svelte-kit
that referenced
this issue
Apr 27, 2022
fixes sveltejs#4442, fixes sveltejs#2843 - add manifest.prefix and builder.getAppPrefixDirectory() - adapter-cloudflare*: use manifest.prefix instead of manifest.appDir - adapter-netlify: use prefixed appDir for cache headers - adapter-vercel: use prefixed appDir for routes.json - adapter-cloudflare, adapter-cloudflare-workers, adapter-netlify: write static assets to "$dest/$base"
hmnd
added a commit
to hmnd/svelte-kit
that referenced
this issue
Apr 27, 2022
fixes sveltejs#4442, fixes sveltejs#2843 - add manifest.prefix and builder.getAppPrefixDirectory() - adapter-cloudflare*: use manifest.prefix instead of manifest.appDir - adapter-netlify: use prefixed appDir for cache headers - adapter-vercel: use prefixed appDir for routes.json - adapter-cloudflare, adapter-cloudflare-workers, adapter-netlify: write static assets to "$dest/$base"
hmnd
added a commit
to hmnd/svelte-kit
that referenced
this issue
Jul 22, 2022
fixes sveltejs#4442, fixes sveltejs#2843 - add manifest.prefix and builder.getAppPrefixDirectory() - adapter-cloudflare*: use manifest.prefix instead of manifest.appDir - adapter-netlify: use prefixed appDir for cache headers - adapter-vercel: use prefixed appDir for routes.json - adapter-cloudflare, adapter-cloudflare-workers, adapter-netlify: write static assets to "$dest/$base"
hmnd
added a commit
to hmnd/svelte-kit
that referenced
this issue
Jul 22, 2022
fixes sveltejs#4442, fixes sveltejs#2843 - add manifest.prefix and builder.getAppPrefixDirectory() - adapter-cloudflare*: use manifest.prefix instead of manifest.appDir - adapter-netlify: use prefixed appDir for cache headers - adapter-vercel: use prefixed appDir for routes.json - adapter-cloudflare, adapter-cloudflare-workers, adapter-netlify: write static assets to "$dest/$base"
hmnd
added a commit
to hmnd/svelte-kit
that referenced
this issue
Jul 22, 2022
fixes sveltejs#4442, fixes sveltejs#2843 - add manifest.prefix and builder.getAppPrefixDirectory() - adapter-cloudflare*: use manifest.prefix instead of manifest.appDir - adapter-netlify: use prefixed appDir for cache headers - adapter-vercel: use prefixed appDir for routes.json - adapter-cloudflare, adapter-cloudflare-workers, adapter-netlify: write static assets to "$dest/$base"
hmnd
added a commit
to hmnd/svelte-kit
that referenced
this issue
Sep 2, 2022
fixes sveltejs#4442, fixes sveltejs#2843 - add manifest.prefix and builder.getAppPrefixDirectory() - adapter-cloudflare*: use manifest.prefix instead of manifest.appDir - adapter-netlify: use prefixed appDir for cache headers - adapter-vercel: use prefixed appDir for routes.json - adapter-cloudflare, adapter-cloudflare-workers, adapter-netlify: write static assets to "$dest/$base"
hmnd
added a commit
to hmnd/svelte-kit
that referenced
this issue
Sep 2, 2022
fixes sveltejs#4442, fixes sveltejs#2843 - add manifest.prefix and builder.getAppPrefixDirectory() - adapter-cloudflare*: use manifest.prefix instead of manifest.appDir - adapter-netlify: use prefixed appDir for cache headers - adapter-vercel: use prefixed appDir for routes.json - adapter-cloudflare, adapter-cloudflare-workers, adapter-netlify: write static assets to "$dest/$base"
hmnd
added a commit
to hmnd/svelte-kit
that referenced
this issue
Sep 2, 2022
fixes sveltejs#4442, fixes sveltejs#2843 - add manifest.prefix and builder.getAppPrefixDirectory() - adapter-cloudflare*: use manifest.prefix instead of manifest.appDir - adapter-netlify: use prefixed appDir for cache headers - adapter-vercel: use prefixed appDir for routes.json - adapter-cloudflare, adapter-cloudflare-workers, adapter-netlify: write static assets to "$dest/$base"
hmnd
added a commit
to hmnd/svelte-kit
that referenced
this issue
Sep 16, 2022
fixes sveltejs#4442, fixes sveltejs#2843 - add manifest.prefix and builder.getAppPrefixDirectory() - adapter-cloudflare*: use manifest.prefix instead of manifest.appDir - adapter-netlify: use prefixed appDir for cache headers - adapter-vercel: use prefixed appDir for routes.json - adapter-cloudflare, adapter-cloudflare-workers, adapter-netlify: write static assets to "$dest/$base"
hmnd
added a commit
to hmnd/svelte-kit
that referenced
this issue
Sep 29, 2022
fixes sveltejs#4442, fixes sveltejs#2843 - add manifest.appPath and builder.getAppPath() - adapter-cloudflare*: use manifest.appPath instead of manifest.appDir - adapter-netlify: use prefixed appDir for cache headers - adapter-vercel: use prefixed appDir for routes.json - adapter-cloudflare, adapter-cloudflare-workers, adapter-netlify: write static assets to "$dest/$base"
hmnd
added a commit
to hmnd/svelte-kit
that referenced
this issue
Sep 30, 2022
fixes sveltejs#4442, fixes sveltejs#2843 - add manifest.appPath and builder.getAppPath() - adapter-cloudflare*: use manifest.appPath instead of manifest.appDir - adapter-netlify: use prefixed appDir for cache headers - adapter-vercel: use prefixed appDir for routes.json - adapter-cloudflare, adapter-cloudflare-workers, adapter-netlify: write static assets to "$dest/$base"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
paths.base
bugs relating to `config.kit.paths.base`
pkg:adapter-cloudflare
Describe the bug
I wish to use multiple SvelteKit apps on one domain, hence I must use
base
to separate them, to avoid each one of them thinking they are special and get to own the URL/_app
.If I set
svelte.config.js
config.kit.paths.base = '/foo'
, and use the@sveltejs/adapter-cloudflare
adapter,npx wrangler@beta pages dev .svelte-kit/cloudflare/
results in it not finding the assets.It seems SvelteKit assumes that the assets are served with
base
as a prefix (that is, file_app
at the root of the static files is found by the browser at${base}/_app
), while the adapter never considers the value ofbase
.Reproduction
(sorry, not yet done)
Logs
No response
System Info
Severity
serious, but I can work around it
Additional Information
No response
The text was updated successfully, but these errors were encountered: