Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle hook should accept { request, render } rather than positional parameters #958

Closed
Conduitry opened this issue Apr 10, 2021 · 2 comments · Fixed by #959
Closed

handle hook should accept { request, render } rather than positional parameters #958

Conduitry opened this issue Apr 10, 2021 · 2 comments · Fixed by #959
Labels
task Things that need to be done
Milestone

Comments

@Conduitry
Copy link
Member

Is your feature request related to a problem? Please describe.
Public APIs should be future proofed, and should avoid positional parameters

Describe the solution you'd like
The handle hook should accept a single argument with { request, render } as an object, rather than as two separate arguments.

Describe alternatives you've considered
Not really.

How important is this feature to you?
We should get this in before 1.0, because it is breaking.

Additional context
I ran this by Rich on Discord first, and he approves.

@Conduitry Conduitry added the task Things that need to be done label Apr 10, 2021
@Conduitry Conduitry added this to the 1.0 milestone Apr 10, 2021
Rich-Harris pushed a commit to Conduitry/kit that referenced this issue Apr 12, 2021
@Conduitry
Copy link
Member Author

@Rich-Harris #959 hasn't been merged, why was this closed?

@Conduitry Conduitry reopened this Apr 12, 2021
@Rich-Harris
Copy link
Member

d'oh, i thought it had been merged. i was tired

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Things that need to be done
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants