Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update vite #1622

Closed
wants to merge 2 commits into from
Closed

update vite #1622

wants to merge 2 commits into from

Conversation

dominikg
Copy link
Member

@dominikg dominikg commented Jun 1, 2021

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

This PR is going to fail at tests. I'm expecting that and the fail will be used to file a regression at vite

Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
@dominikg
Copy link
Member Author

dominikg commented Jun 2, 2021

damnit, shouldn't have merged that from github... going to start over in a new one

@dominikg dominikg closed this Jun 2, 2021
@dominikg dominikg mentioned this pull request Jun 2, 2021
5 tasks
@dominikg dominikg deleted the update-vite branch June 19, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants