Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert avoid css leaking into emitted javascript (#3402) #3630

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

dominikg
Copy link
Contributor

@dominikg dominikg commented Jun 1, 2021

…fix for #3610 and partial fix for #2282

This reverts commit 65d333d

Description

The PR #3402 changed the content of css modules to empty string which causes failures for sveltekit testsuite: sveltejs/kit#1622 and also other issues, see #3610 and #2282

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev requested a review from antfu June 1, 2021 21:41
@patak-dev patak-dev changed the title fix: Revert "fix: avoid css leaking into emitted javascript (#3402)" … fix: revert avoid css leaking into emitted javascript (#3402) Jun 2, 2021
@patak-dev patak-dev merged commit 91eb2a6 into vitejs:main Jun 2, 2021
@Dreamacro
Copy link

#2144 fixed on 2.3.5. After reverting this commit, it compiled CSS twice.

@dominikg
Copy link
Contributor Author

dominikg commented Jun 3, 2021

Thank you for pointing that out. The revert happened because the change had caused multiple regressions. A proper fix needs to take this into account.

The original PR #3402 intention was to remove an unreferenced variable from js build output. Maybe we should try to find out why this wasn't removed during treeshaking/minification.

Another option would be to check if the regressions were all happening on serve and only remove the css export on build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants