Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] adapter-netlify: support for multivalue headers #1906

Merged

Conversation

JeanJPNM
Copy link
Contributor

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Fixes #1741 by moving set-cookie to multiValueHeaders whenever it sets more than one cookie.

@changeset-bot
Copy link

changeset-bot bot commented Jul 14, 2021

🦋 Changeset detected

Latest commit: 29c9c3c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-netlify Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann benmccann added pkg:adapter-netlify bug Something isn't working labels Jul 14, 2021
@benmccann
Copy link
Member

This looks pretty good to me. The one thing I wonder though is if it's the case that Set-Cookie is the only multi-value header that will ever exist. I might be safer to iterate though and check which headers have multiple values rather than specifying a list of headers to check

@benmccann benmccann merged commit 9461178 into sveltejs:master Jul 14, 2021
@benmccann
Copy link
Member

thanks!!

@JeanJPNM JeanJPNM deleted the adapter-netlify-multivalue-headers branch July 14, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pkg:adapter-netlify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adapter-netlify: Support multiValueHeaders key in returned object from handler function
2 participants