Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] update to TS 4.4.3 #2432

Merged
merged 2 commits into from
Sep 15, 2021
Merged

[fix] update to TS 4.4.3 #2432

merged 2 commits into from
Sep 15, 2021

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Sep 15, 2021 •
edited
Loading

Closes #2322

I chose a mix of "just type it as any" and coalescing the errors.

The pnpm lock file contains TS 4.3.5, too, and I don't know how to get rid of it. Help appreciated.

Deliberately no changelog, as it's only internally in my opinion.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: f763edc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@benmccann
Copy link
Member

The pnpm lock file contains TS 4.3.5, too, and I don't know how to get rid of it. Help appreciated.

I found typescript mentioned in the files below:

packages/create-svelte/templates/default/package.json:		"typescript": "^4.3.5"
packages/create-svelte/shared/+typescript/package.json:		"typescript": "^4.0.0",

Maybe we should just make both of them ^4.0.0 so that we don't have to update it for minor releases?

@dummdidumm dummdidumm marked this pull request as ready for review September 15, 2021 16:58
@dummdidumm
Copy link
Member Author

I solved it by bumping other packages (which is good anyway)

benmccann
benmccann approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!! 1 ticket closer to 1.0 😄

@benmccann benmccann merged commit d8efaa2 into master Sep 15, 2021
@benmccann benmccann deleted the bump-ts branch September 15, 2021 17:17
sidharthv96 added a commit to sidharthv96/kit that referenced this pull request Sep 19, 2021
@sidharthv96
Merge branch 'master' of https://github.com/sveltejs/kit
d5059c5 
* 'master' of https://github.com/sveltejs/kit: (322 commits)
  Version Packages (next) (sveltejs#2438)
  [fix] revert sveltejs#2354 and fix double character decoding a different way (sveltejs#2435)
  chore: update dependencies (sveltejs#2447)
  [docs] add link to envPrefix option in env var FAQ (sveltejs#2445)
  Fix invalid changeset. Thanks GitHub bot :-p
  [feat] use the Vite server options in dev mode (sveltejs#2232)
  [fix] provide valid value for `letter-spacing` CSS property in template (sveltejs#2437)
  [docs] fix typo (sveltejs#2443)
  [fix] add svelte field when packaging (sveltejs#2431)
  Version Packages (next) (sveltejs#2428)
  [chore] update lockfile
  [fix] update to TS 4.4.3 (sveltejs#2432)
  [chore] add links to repository and homepage to package.json (sveltejs#2425)
  docs: use fragment for prefetching link (sveltejs#2429)
  [fix] encodeURI during prerender (sveltejs#2427)
  Version Packages (next) (sveltejs#2420)
  revert change to versioning during release workflow
  chore: update vite-plugin-svelte (sveltejs#2423)
  [chore] expose Body generic to hook functions (sveltejs#2413)
  [feat] adapter-node entryPoint option (sveltejs#2414)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to TypeScript 4.4
2 participants
@dummdidumm @benmccann