[fix] revert #2354 and fix double character decoding a different way #2435
Conversation
🦋 Changeset detectedLatest commit: ce76e03 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -231,15 +231,31 @@ function get_params(array) { | |||
| // src/routes/[x]/[y]/[z]/svelte, create a function | |||
| // that turns a RegExpExecArray into ({ x, y, z }) | |||
|
|
|||
| // input has already been decoded by decodeURI | |||
| // now handle the rest that decodeURIComponent would do | |||
| const d = /** @param {string} s */ (s) => | |||
There was a problem hiding this comment.
This looks the same like in build - maybe put it into a common file for both to use? utils/encoding.js or something like that.
There was a problem hiding this comment.
Yeah, it is the same, but I'm not sure it's that easy to share code between the two because the one in build is a string that gets written out to a file and isn't normal code. I think I could still do it, but would probably need to setup a new file to be output in the Rollup config as well. I'm just not sure it's worth it at the moment given all the other stuff there is to do though I do agree it'd be nicer
|
I'm going to go ahead and merge this since we just got another report of it in #2451 |
* 'master' of https://github.com/sveltejs/kit: (322 commits) Version Packages (next) (sveltejs#2438) [fix] revert sveltejs#2354 and fix double character decoding a different way (sveltejs#2435) chore: update dependencies (sveltejs#2447) [docs] add link to envPrefix option in env var FAQ (sveltejs#2445) Fix invalid changeset. Thanks GitHub bot :-p [feat] use the Vite server options in dev mode (sveltejs#2232) [fix] provide valid value for `letter-spacing` CSS property in template (sveltejs#2437) [docs] fix typo (sveltejs#2443) [fix] add svelte field when packaging (sveltejs#2431) Version Packages (next) (sveltejs#2428) [chore] update lockfile [fix] update to TS 4.4.3 (sveltejs#2432) [chore] add links to repository and homepage to package.json (sveltejs#2425) docs: use fragment for prefetching link (sveltejs#2429) [fix] encodeURI during prerender (sveltejs#2427) Version Packages (next) (sveltejs#2420) revert change to versioning during release workflow chore: update vite-plugin-svelte (sveltejs#2423) [chore] expose Body generic to hook functions (sveltejs#2413) [feat] adapter-node entryPoint option (sveltejs#2414) ...
Fixes #2401
Reverts most of #2354, but leaves the test for #1746