Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore mailto: links etc #2915

Merged
merged 2 commits into from Nov 25, 2021
Merged

ignore mailto: links etc #2915

merged 2 commits into from Nov 25, 2021

Conversation

Rich-Harris
Copy link
Member

Ignores mailto: and tel: and data: etc links when prerendering. Fixes #2909

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2021

🦋 Changeset detected

Latest commit: 5096d7b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@dominikg dominikg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this exits early for http: and https: too but thats likely what we want anyways.

@Rich-Harris Rich-Harris merged commit 3365f0b into master Nov 25, 2021
@Rich-Harris Rich-Harris deleted the gh-2909 branch November 25, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mailto links broke with 1.0.0-next.200
2 participants