-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mailto links broke with 1.0.0-next.200 #2909
Closed
philippdormann opened this issue
Nov 24, 2021
· 4 comments
· Fixed by #2915 · May be fixed by naiba4/kit#1
Closed
mailto links broke with 1.0.0-next.200 #2909
philippdormann opened this issue
Nov 24, 2021
· 4 comments
· Fixed by #2915 · May be fixed by naiba4/kit#1
Labels
bug
Something isn't working
p1-important
SvelteKit cannot be used by a large number of people, basic functionality is missing, etc.
Milestone
Comments
I had exactly the same issue, with mailto and tel links, and also parent-child related links where parent URL does not exist. #2913 |
Experiencing same issue with mailto and tel links, 1.0.0-next.199 works fine. |
antony
added
the
p1-important
SvelteKit cannot be used by a large number of people, basic functionality is missing, etc.
label
Nov 25, 2021
Rich-Harris
added a commit
that referenced
this issue
Nov 25, 2021
Rich-Harris
added a commit
that referenced
this issue
Nov 25, 2021
* ignore hrefs with a scheme - fixes #2909 * changeset
thanks — fixed in 201 |
I'm getting the same following error while using a mailto: URL in the goto function:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
p1-important
SvelteKit cannot be used by a large number of people, basic functionality is missing, etc.
Describe the bug
when running
npm run build
on a kit@1.0.0-next.200 project, the build fails when processing mailto: links.I think the commit f12bbcc (is_root_relative helper) might be related to this issue
Reproduction
https://stackblitz.com/github/philippdormann/sveltekit-next-200-reproduction-mailto
https://github.com/philippdormann/sveltekit-next-200-reproduction-mailto
Logs
System Info
Severity
annoyance
Additional Information
everything works fine on 1.0.0-next.199
The text was updated successfully, but these errors were encountered: