Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] prerender with parse5 #2923

Closed
wants to merge 3 commits into from
Closed

[fix] prerender with parse5 #2923

wants to merge 3 commits into from

Conversation

si3nloong
Copy link
Contributor

@si3nloong si3nloong commented Nov 26, 2021

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

This PR specifically solves issues of #2645, #2713, and #2742.

Nevertheless, I need to write more tests for this.

@changeset-bot
Copy link

changeset-bot bot commented Nov 26, 2021

⚠️ No Changeset found

Latest commit: 8b8b780

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@si3nloong si3nloong changed the title fix: prerender with parse5 [fix] prerender with parse5 Nov 27, 2021
@gg187on
Copy link

gg187on commented Dec 6, 2021

Can we add here tests for when href contain data:image or > character? See my PR, and maybe You can use something from tests in my PR (ofc it would need some tweaks so it works with parse5, I mean You can maybe extract code that parse specific tag to "global" scope (of file) and export it for tests)?

@Rich-Harris
Copy link
Member

Thank you — closing in favour of #3288

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants