Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crawl prerendered pages without regex hackery #3288

Merged
merged 19 commits into from Jan 11, 2022
Merged

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Jan 11, 2022

This is an alternative to #2923. It prevents the sort of bugs that can arise when you're extracting attributes with regex...

<img data-something=" src=" crossorigin src="dog>cat.png"> crazy link </img>

...without the overhead of fully parsing the HTML. parse5 is great, but it's much too large to add on a whim, and does far more than we need. This implementation takes a tiny fraction of the size (it adds less than 100LOC) and is roughly 3x faster (I'm sure someone suitably motivated could make it faster still), which is important in this context.

Fixes #2645 and #2742.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@netlify
Copy link

netlify bot commented Jan 11, 2022

✔️ Deploy Preview for kit-demo ready!

🔨 Explore the source changes: 9847466

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61ddcd2709e5710007cf0a8e

😎 Browse the preview: https://deploy-preview-3288--kit-demo.netlify.app

@changeset-bot
Copy link

changeset-bot bot commented Jan 11, 2022

🦋 Changeset detected

Latest commit: 9847466

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JackPriceBurns
Copy link

@Rich-Harris in packages/kit/src/core/adapt/prerender/fixtures/large-page/input.html can we also add some <source> and <img> tags with the attributes in different places to ensure that #2742 never happens again (will protect us from regressions if we ever decide to move to parse5 or something else later)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adapter-static data:image URL error 404
3 participants