-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[adapter-cloudflare] Update static file logic to allow spaces in filenames #3047
Conversation
🦋 Changeset detectedLatest commit: 64c1047 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
Co-authored-by: Luke Edwards <luke.edwards05@gmail.com>
the |
Sorry! Fixed now. |
This PR makes the Worker URL-decode any received paths so that static files with spaces in the filename can be found.
Without this change, accessing a static file that has a space in it (for example,
https://example.com/Example File.pdf
) fails. This is because:ASSETS
Set with a space (non-URL encoded).%20
, as it should.ASSETS
Set with%20
instead of space (I've tested this change on my own local copy of adapter-cloudflare in production and it works.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0