Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allows for __tests__ & __test__ directories #4438

Merged
merged 5 commits into from
Mar 31, 2022

Conversation

cmcculloh-kr
Copy link

fixes #4435

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Mar 23, 2022

🦋 Changeset detected

Latest commit: 0f485d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rmunn
Copy link
Contributor

rmunn commented Mar 28, 2022

I'd suggest also allowing __test__ in addition to __tests__, because I've seen both test and tests being used as directory names in projects I've been involved with. So while I haven't personally seen either __test__ or __tests__ myself, I wouldn't be surprised if both are in use, with more or less equal usage (I'd guess). So if we're special-casing one, we should special-case both and do it in the same PR so we don't have to revisit the question later on when someone asks for __test__.

@cmcculloh-kr cmcculloh-kr changed the title allows for __tests__ directories allows for __tests__ & __test__ directories Mar 28, 2022
@Rich-Harris Rich-Harris merged commit a11bae8 into sveltejs:master Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

__tests__ directories break the build
6 participants