Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify Node version requirement #464

Closed
wants to merge 2 commits into from
Closed

Conversation

GrygrFlzr
Copy link
Member

Closes #354.

  • Accept 12.17.0+
  • Accept 14.13.0+
  • Decline 13.x

On unsupported versions, the following message will appear when attempting to run e.g. pnpm test:

$ pnpm test
 WARN  Unsupported engine: wanted: {"node":">= 12.17.0 < 13.0.0 || >= 14.13.0"} (current: {"node":"v14.12.0","pnpm":"5.18.3"})

- Accept 12.17.0+
- Accept 14.13.0+
- Decline 13.x
@Rich-Harris
Copy link
Member

I think we can fix #354 without restricting SvelteKit to specific Node versions: #465

I'm confused by these Windows test failures though, they seem to be happening on all PRs and I've no clue what could be causing it. Any ideas?

@GrygrFlzr
Copy link
Member Author

Windows test failures will not be fixed until #460 is fixed, which requires a change in Vite. I've detailed the bug and the offending line over at the vite repo (vitejs/vite#2422), but I haven't yet come up with a fix that doesn't cause half the tests to fail.

@Rich-Harris
Copy link
Member

Oof. Thanks for investigating, will keep an eye on that issue

@benmccann benmccann mentioned this pull request Mar 8, 2021
@benmccann benmccann closed this Mar 10, 2021
@Conduitry Conduitry deleted the node-version-req branch April 1, 2021 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing "error in endpoint" test for Node 14.12 and below
3 participants