Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #354 test failure #465

Closed
wants to merge 2 commits into from
Closed

fix #354 test failure #465

wants to merge 2 commits into from

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris
Copy link
Member Author

There's something weird going on here — it's failing to build svelte-kit-demo

@benmccann
Copy link
Member

I can confirm the tests pass on my old machine with this change

@benmccann
Copy link
Member

Running npm run dev and then visiting localhost:3000 on the svelte-kit-demo gives:

TypeError: Response is not a constructor
    at fetcher (packages/kit/dist/ssr.js:2075:17)
    at async load (/home/bmccann/src/kit/examples/svelte-kit-demo/src/routes/blog/index.svelte:5:11)
    at async get_response (packages/kit/dist/ssr.js:2138:6)
    at async render_page (packages/kit/dist/ssr.js:2344:9)
    at async ssr (packages/kit/dist/ssr.js:2482:20)
    at async Immediate.<anonymous> (packages/kit/dist/chunks/index.js:3278:23)

@benmccann benmccann mentioned this pull request Mar 8, 2021
@Conduitry Conduitry deleted the gh-354 branch April 1, 2021 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants